public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Bastian Germann <bage@debian.org>
Cc: linux-xfs@vger.kernel.org, Boian Bonev <bbonev@ipacct.com>
Subject: Re: [PATCH v2 3/4] debian: Fix FTBFS
Date: Mon, 15 Nov 2021 08:54:00 -0800	[thread overview]
Message-ID: <20211115165400.GG24307@magnolia> (raw)
In-Reply-To: <20211114224339.20246-4-bage@debian.org>

On Sun, Nov 14, 2021 at 11:43:38PM +0100, Bastian Germann wrote:
> From: Boian Bonev <bbonev@ipacct.com>
> 
> With newer autotools install-sh is regenerated by libtoolize.
> Copy the package's version after autogen.
> 
> Link: https://bugs.debian.org/997656
> Signed-off-by: Boian Bonev <bbonev@ipacct.com>
> Signed-off-by: Bastian Germann <bage@debian.org>

/me wonders what exactly about our install-sh is so unique -- I guess
it's DIST_ROOT (being picked up from DESTDIR?) and copying things to
different locations?

As a strict "just keep the keys out of the fire hose" measure this looks
ok to me though.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  debian/rules | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian/rules b/debian/rules
> index e12814b3..615289b4 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -50,6 +50,7 @@ config: .census
>  	AUTOHEADER=/bin/true dh_autoreconf
>  	dh_update_autotools_config
>  	$(options) $(MAKE) $(PMAKEFLAGS) include/platform_defs.h
> +	cp -f include/install-sh .
>  	touch .census
>  
>  dibuild:
> -- 
> 2.33.1
> 
> 

  reply	other threads:[~2021-11-15 16:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 22:43 [PATCH v2 0/4] xfsprogs debian updates Bastian Germann
2021-11-14 22:43 ` [PATCH v2 1/4] debian: Update Uploaders list Bastian Germann
2021-11-14 22:43 ` [PATCH v2 2/4] debian: Pass --build and --host to configure Bastian Germann
2021-11-14 22:43 ` [PATCH v2 3/4] debian: Fix FTBFS Bastian Germann
2021-11-15 16:54   ` Darrick J. Wong [this message]
2021-11-15 18:05     ` Boian Bonev
2021-11-14 22:43 ` [PATCH v2 4/4] debian: Add changelog entry for 5.14.0-rc1-1 Bastian Germann
2021-11-15 16:54   ` Darrick J. Wong
2021-11-15 18:53 ` [PATCH v2 0/4] xfsprogs debian updates Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211115165400.GG24307@magnolia \
    --to=djwong@kernel.org \
    --cc=bage@debian.org \
    --cc=bbonev@ipacct.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox