From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 10/16] xfs: change the type of ic_datap
Date: Tue, 16 Nov 2021 20:50:45 -0800 [thread overview]
Message-ID: <20211117045045.GR24307@magnolia> (raw)
In-Reply-To: <20211109015055.1547604-11-david@fromorbit.com>
On Tue, Nov 09, 2021 at 12:50:49PM +1100, Dave Chinner wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Turn ic_datap from a char into a void pointer given that it points
> to arbitrary data.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
> Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
> [dgc: also remove (char *) cast in xlog_alloc_log()]
> Signed-off-by: Dave Chinner <david@fromorbit.com>
Gosh, I actually like the syntax highlighting in lore for reading
patches.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_log.c | 7 +++----
> fs/xfs/xfs_log_priv.h | 2 +-
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 76d5a743f6fb..f26c85dbc765 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1658,7 +1658,7 @@ xlog_alloc_log(
> iclog->ic_log = log;
> atomic_set(&iclog->ic_refcnt, 0);
> INIT_LIST_HEAD(&iclog->ic_callbacks);
> - iclog->ic_datap = (char *)iclog->ic_data + log->l_iclog_hsize;
> + iclog->ic_datap = (void *)iclog->ic_data + log->l_iclog_hsize;
>
> init_waitqueue_head(&iclog->ic_force_wait);
> init_waitqueue_head(&iclog->ic_write_wait);
> @@ -3678,7 +3678,7 @@ xlog_verify_iclog(
> if (field_offset & 0x1ff) {
> clientid = ophead->oh_clientid;
> } else {
> - idx = BTOBBT((char *)&ophead->oh_clientid - iclog->ic_datap);
> + idx = BTOBBT((void *)&ophead->oh_clientid - iclog->ic_datap);
> if (idx >= (XLOG_HEADER_CYCLE_SIZE / BBSIZE)) {
> j = idx / (XLOG_HEADER_CYCLE_SIZE / BBSIZE);
> k = idx % (XLOG_HEADER_CYCLE_SIZE / BBSIZE);
> @@ -3701,8 +3701,7 @@ xlog_verify_iclog(
> if (field_offset & 0x1ff) {
> op_len = be32_to_cpu(ophead->oh_len);
> } else {
> - idx = BTOBBT((uintptr_t)&ophead->oh_len -
> - (uintptr_t)iclog->ic_datap);
> + idx = BTOBBT((void *)&ophead->oh_len - iclog->ic_datap);
> if (idx >= (XLOG_HEADER_CYCLE_SIZE / BBSIZE)) {
> j = idx / (XLOG_HEADER_CYCLE_SIZE / BBSIZE);
> k = idx % (XLOG_HEADER_CYCLE_SIZE / BBSIZE);
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index 56df86d62430..51254d7f38d6 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -190,7 +190,7 @@ typedef struct xlog_in_core {
> u32 ic_offset;
> enum xlog_iclog_state ic_state;
> unsigned int ic_flags;
> - char *ic_datap; /* pointer to iclog data */
> + void *ic_datap; /* pointer to iclog data */
> struct list_head ic_callbacks;
>
> /* reference counts need their own cacheline */
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-11-17 4:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 1:50 [PATCH 00/16 v6] xfs: rework xlog_write() Dave Chinner
2021-11-09 1:50 ` [PATCH 01/16] xfs: factor out the CIL transaction header building Dave Chinner
2021-11-09 1:50 ` [PATCH 02/16] xfs: only CIL pushes require a start record Dave Chinner
2021-11-11 7:55 ` Christoph Hellwig
2021-11-18 4:38 ` Dave Chinner
2021-11-09 1:50 ` [PATCH 03/16] xfs: embed the xlog_op_header in the unmount record Dave Chinner
2021-11-09 1:50 ` [PATCH 04/16] xfs: embed the xlog_op_header in the commit record Dave Chinner
2021-11-11 8:00 ` Christoph Hellwig
2021-11-18 4:43 ` Dave Chinner
2021-11-09 1:50 ` [PATCH 05/16] xfs: log tickets don't need log client id Dave Chinner
2021-11-09 1:50 ` [PATCH 06/16] xfs: move log iovec alignment to preparation function Dave Chinner
2021-11-09 1:50 ` [PATCH 07/16] xfs: reserve space and initialise xlog_op_header in item formatting Dave Chinner
2021-11-11 8:10 ` Christoph Hellwig
2021-11-09 1:50 ` [PATCH 08/16] xfs: log ticket region debug is largely useless Dave Chinner
2021-11-09 1:50 ` [PATCH 09/16] xfs: pass lv chain length into xlog_write() Dave Chinner
2021-11-11 8:10 ` Christoph Hellwig
2021-11-09 1:50 ` [PATCH 10/16] xfs: change the type of ic_datap Dave Chinner
2021-11-17 4:50 ` Darrick J. Wong [this message]
2021-11-09 1:50 ` [PATCH 11/16] xfs: introduce xlog_write_full() Dave Chinner
2021-11-11 8:12 ` Christoph Hellwig
2021-11-17 4:56 ` Darrick J. Wong
2021-11-09 1:50 ` [PATCH 12/16] xfs:_introduce xlog_write_partial() Dave Chinner
2021-11-11 8:27 ` Christoph Hellwig
2021-11-17 5:21 ` Darrick J. Wong
2021-11-18 5:22 ` Dave Chinner
2021-11-09 1:50 ` [PATCH 13/16] xfs: remove xlog_verify_dest_ptr Dave Chinner
2021-11-17 5:02 ` Darrick J. Wong
2021-11-09 1:50 ` [PATCH 14/16] xfs: xlog_write() no longer needs contwr state Dave Chinner
2021-11-11 8:28 ` Christoph Hellwig
2021-11-09 1:50 ` [PATCH 15/16] xfs: xlog_write() doesn't need optype anymore Dave Chinner
2021-11-11 8:29 ` Christoph Hellwig
2021-11-09 1:50 ` [PATCH 16/16] xfs: CIL context doesn't need to count iovecs Dave Chinner
2021-11-11 8:29 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2021-11-18 23:13 [PATCH 00/16 v7] xfs: rework xlog_write() Dave Chinner
2021-11-18 23:13 ` [PATCH 10/16] xfs: change the type of ic_datap Dave Chinner
2022-03-09 5:29 [PATCH 00/16 v8] xfs: rework xlog_write() Dave Chinner
2022-03-09 5:29 ` [PATCH 10/16] xfs: change the type of ic_datap Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117045045.GR24307@magnolia \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).