From: "Darrick J. Wong" <djwong@kernel.org>
To: Bastian Germann <bage@debian.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] debian: Generate .gitcensus instead of .census (Closes: #999743)
Date: Tue, 23 Nov 2021 12:08:11 -0800 [thread overview]
Message-ID: <20211123200811.GC266024@magnolia> (raw)
In-Reply-To: <20211119171241.102173-2-bage@debian.org>
On Fri, Nov 19, 2021 at 06:12:40PM +0100, Bastian Germann wrote:
> Fix the Debian build outside a git tree (e.g., Debian archive builds) by
> creating an empty .gitcensus instead of .census file on config.
>
> Signed-off-by: Bastian Germann <bage@debian.org>
Heh. I used to have a patch that more or less did this, until I
switched to building development packages only from git. Sorry I forgot
to come back to this one.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> debian/rules | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/debian/rules b/debian/rules
> index 615289b4..6d5b82a8 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -43,15 +43,15 @@ built: dibuild config
> $(MAKE) $(PMAKEFLAGS) default
> touch built
>
> -config: .census
> -.census:
> +config: .gitcensus
> +.gitcensus:
> @echo "== dpkg-buildpackage: configure" 1>&2
> $(checkdir)
> AUTOHEADER=/bin/true dh_autoreconf
> dh_update_autotools_config
> $(options) $(MAKE) $(PMAKEFLAGS) include/platform_defs.h
> cp -f include/install-sh .
> - touch .census
> + touch .gitcensus
>
> dibuild:
> $(checkdir)
> @@ -72,7 +72,7 @@ dibuild:
> clean:
> @echo "== dpkg-buildpackage: clean" 1>&2
> $(checkdir)
> - -rm -f built .census mkfs/mkfs.xfs-$(bootpkg)
> + -rm -f built .gitcensus mkfs/mkfs.xfs-$(bootpkg)
> $(MAKE) distclean
> -rm -rf $(dirme) $(dirdev) $(dirdi)
> -rm -f debian/*substvars debian/files* debian/*.debhelper
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2021-11-23 20:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 17:12 [PATCH 0/2] debian: Fix xfsprogs FT(C)BFS Bastian Germann
2021-11-19 17:12 ` [PATCH 1/2] debian: Generate .gitcensus instead of .census (Closes: #999743) Bastian Germann
2021-11-23 20:01 ` Bastian Germann
2021-11-23 20:08 ` Darrick J. Wong [this message]
2021-11-19 17:12 ` [PATCH 2/2] debian: Fix FTCBFS: Skip crc32 test (Closes: #999879) Bastian Germann
2021-11-19 23:11 ` Dave Chinner
2021-11-20 7:32 ` Helmut Grohne
2021-11-20 17:15 ` Darrick J. Wong
2021-11-20 22:20 ` Dave Chinner
2021-11-20 22:27 ` Dave Chinner
2021-11-22 23:32 ` Darrick J. Wong
2021-11-22 23:31 ` Darrick J. Wong
2021-11-22 23:37 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123200811.GC266024@magnolia \
--to=djwong@kernel.org \
--cc=bage@debian.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).