From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09931C433F5 for ; Wed, 5 Jan 2022 17:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242194AbiAERVV (ORCPT ); Wed, 5 Jan 2022 12:21:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242193AbiAERVV (ORCPT ); Wed, 5 Jan 2022 12:21:21 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D90CC061245 for ; Wed, 5 Jan 2022 09:21:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BEB8AB80462 for ; Wed, 5 Jan 2022 17:21:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D306C36AE3; Wed, 5 Jan 2022 17:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641403278; bh=kIe9tBzKJ8q88QCt80XcfKWAW07bKc/enRaM/N4xTjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cA/yxWUKd0Ee1Z1Lj8oFTc88ZLgIXkdpGQECV4gRXgjaXQ6cVf7I8gM9kE0LEXIjx dt3hN8cR3VOBWbr9YwuYdAFBmFHnNSyZMOV2dO5JMrCylEthtwl6GicwdEbjQoa7wZ ChG5HS1rhTaHDHwghacrGX+HB3JCA0UwH3Imqg/asPpoyoOrNM1Puk24HIyOVyGrjE W2UxbgLDSDogE2ddZANMnpL8iYlOTSYUT2w/B6afTdeoTllhZjxGv9z4Jyi2ivLvBD Ko5rFMjMDtyujR2MZiBrY7gZqWnOdHIemuBdM1MNNOUk/yc5G542hWeN6+qOG5c/Uu jCRHfkCGOot9g== Date: Wed, 5 Jan 2022 09:21:17 -0800 From: "Darrick J. Wong" To: Chandan Babu R Cc: kernel test robot , linux-xfs@vger.kernel.org, kbuild-all@lists.01.org, david@fromorbit.com Subject: Re: [PATCH V4 06/16] xfs: Promote xfs_extnum_t and xfs_aextnum_t to 64 and 32-bits respectively Message-ID: <20220105172117.GH656707@magnolia> References: <20211214084519.759272-7-chandan.babu@oracle.com> <202112142335.O3Nu0vQI-lkp@intel.com> <87a6h22pjf.fsf@debian-BULLSEYE-live-builder-AMD64> <20220104235457.GM31583@magnolia> <87h7ai8e2o.fsf@debian-BULLSEYE-live-builder-AMD64> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h7ai8e2o.fsf@debian-BULLSEYE-live-builder-AMD64> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jan 05, 2022 at 07:44:23PM +0530, Chandan Babu R wrote: > On 05 Jan 2022 at 05:24, Darrick J. Wong wrote: > > On Wed, Dec 15, 2021 at 02:49:48PM +0530, Chandan Babu R wrote: > >> On 14 Dec 2021 at 20:45, kernel test robot wrote: > >> > Hi Chandan, > >> > > >> > Thank you for the patch! Yet something to improve: > >> > > >> > [auto build test ERROR on xfs-linux/for-next] > >> > [also build test ERROR on v5.16-rc5] > >> > [If your patch is applied to the wrong git tree, kindly drop us a note. > >> > And when submitting patch, we suggest to use '--base' as documented in > >> > https://git-scm.com/docs/git-format-patch] > >> > > >> > url: https://github.com/0day-ci/linux/commits/Chandan-Babu-R/xfs-Extend-per-inode-extent-counters/20211214-164920 > >> > base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next > >> > config: microblaze-randconfig-r016-20211214 (https://download.01.org/0day-ci/archive/20211214/202112142335.O3Nu0vQI-lkp@intel.com/config) > >> > compiler: microblaze-linux-gcc (GCC) 11.2.0 > >> > reproduce (this is a W=1 build): > >> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >> > chmod +x ~/bin/make.cross > >> > # https://github.com/0day-ci/linux/commit/db28da144803c4262c0d8622d736a7d20952ef6b > >> > git remote add linux-review https://github.com/0day-ci/linux > >> > git fetch --no-tags linux-review Chandan-Babu-R/xfs-Extend-per-inode-extent-counters/20211214-164920 > >> > git checkout db28da144803c4262c0d8622d736a7d20952ef6b > >> > # save the config file to linux build tree > >> > mkdir build_dir > >> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash > >> > > >> > If you fix the issue, kindly add following tag as appropriate > >> > Reported-by: kernel test robot > >> > > >> > All errors (new ones prefixed by >>): > >> > > >> > microblaze-linux-ld: fs/xfs/libxfs/xfs_bmap.o: in function `xfs_bmap_compute_maxlevels': > >> >>> (.text+0x10cc0): undefined reference to `__udivdi3' > >> > > >> > >> The fix for the compilation error on 32-bit systems involved invoking do_div() > >> instead of using the regular division operator. I will include the fix in the > >> next version of the patchset. > > > > So, uh, how did you resolve this in the end? > > > > maxblocks = roundup_64(maxleafents, minleafrecs); > > > > and > > > > maxblocks = roundup_64(maxblocks, minnodrecs); > > > > ? > > I had made the following changes, > > maxblocks = maxleafents + minleafrecs - 1; > do_div(maxblocks, minleafrecs); > > and > maxblocks += minnoderecs - 1; > do_div(maxblocks, minnoderecs); > > roundup_64() would cause maxleafents to have a value >= its previous value > right? roundup_64 doesn't alter its parameters, if I'm not mistaken: static inline uint64_t roundup_64(uint64_t x, uint32_t y) { x += y - 1; do_div(x, y); return x * y; } --D > > -- > chandan