Re: [PATCH V5 10/16] xfs: Use xfs_rfsblock_t to count maximum blocks that can be used by BMBT

Darrick J. Wong
2022-01-25T02:11:20Z

On Fri, Jan 21, 2022 at 10:48:51AM +0530, Chandan Babu R wrote:
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>

Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
> fs/xfs/libxfs/xfs_bmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index 6cc7817ff425..1948af000c97 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -53,8 +53,8 @@ xfs_bmap_compute_maxlevels(
> int whichfork) /* data or attr fork */
> {
> xfs_extnum_t maxleafents; /* max leaf entries possible */
> + xfs_rfsblock_t maxblocks; /* max blocks at this level */
> int level; /* btree level */
> - uint maxblocks; /* max blocks at this level */
> int maxrootrecs; /* max records in root block */
> int minleafrecs; /* min records in leaf block */
> int minnoderecs; /* min records in node block */
> @@ -88,7 +88,7 @@ xfs_bmap_compute_maxlevels(
> if (maxblocks <= maxrootrecs)
> maxblocks = 1;
> else
> - maxblocks = (maxblocks + minnoderecs - 1) / minnoderecs;
> + maxblocks = howmany_64(maxblocks, minnoderecs);
> }
> mp->m_bm_maxlevels[whichfork] = level;
> ASSERT(mp->m_bm_maxlevels[whichfork] <= xfs_bmbt_maxlevels_ondisk());
> --
> 2.30.2
>