From: "Darrick J. Wong" <djwong@kernel.org>
To: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs: return error from sync_filesystem during remount
Date: Fri, 4 Feb 2022 18:56:52 -0800 [thread overview]
Message-ID: <20220205025652.GY8313@magnolia> (raw)
From: Darrick J. Wong <djwong@kernel.org>
In xfs_fs_reconfigure, check the return value from sync_filesystem and
fail the remount if there was an internal error.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
fs/xfs/xfs_super.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 4c0dee78b2f8..5f3781879c63 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1831,7 +1831,9 @@ xfs_fs_reconfigure(
if (error)
return error;
- sync_filesystem(mp->m_super);
+ error = sync_filesystem(mp->m_super);
+ if (error)
+ return error;
/* inode32 -> inode64 */
if (xfs_has_small_inums(mp) && !xfs_has_small_inums(new_mp)) {
next reply other threads:[~2022-02-05 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 2:56 Darrick J. Wong [this message]
2022-02-06 22:18 ` [PATCH] xfs: return error from sync_filesystem during remount Dave Chinner
2022-02-07 17:07 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220205025652.GY8313@magnolia \
--to=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox