From: Dave Chinner <david@fromorbit.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: kernel test robot <oliver.sang@intel.com>,
lkp@lists.01.org, lkp@intel.com,
LKML <linux-kernel@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [mm/readahead] a0b99df1aa: xfstests.xfs.421.fail
Date: Tue, 22 Feb 2022 07:55:29 +1100 [thread overview]
Message-ID: <20220221205529.GH59715@dread.disaster.area> (raw)
In-Reply-To: <YhOaJ4cZU/1MiNI2@casper.infradead.org>
On Mon, Feb 21, 2022 at 01:56:55PM +0000, Matthew Wilcox wrote:
> On Mon, Feb 21, 2022 at 04:02:18PM +0800, kernel test robot wrote:
> > commit: a0b99df1aa37d714eb80be5fb54efd56c88a3336 ("mm/readahead: Add large folio readahead")
>
> > xfs/420 - output mismatch (see /lkp/benchmarks/xfstests/results//xfs/420.out.bad)
> > --- tests/xfs/420.out 2022-02-17 11:55:00.000000000 +0000
> > +++ /lkp/benchmarks/xfstests/results//xfs/420.out.bad 2022-02-20 20:34:22.430378506 +0000
> > @@ -13,9 +13,7 @@
> > Seek holes and data in file2
> > Whence Result
> > DATA 0
> > -HOLE 131072
> > -DATA 196608
> > -HOLE 262144
> > +HOLE 524288
>
> Confirm this test now fails. I don't think it's actually a bug,
> though. I think the test is now using larger pages to cache the
> file, and it fails to report that there's a hole in the file.
> Maybe there actually isn't a hole in the file any more; using
> larger pages to cache the file means we'll now write more data
> than we used to.
>
> Adding XFS people for their thoughts.
>
> Complete output:
>
> $ diff -u ../ktest/tests/xfstests/tests/xfs/420.out ktest-out/xfstests/xfs/420.out.bad
> --- ../ktest/tests/xfstests/tests/xfs/420.out 2021-07-05 15:49:45.539887305 -0400
> +++ ktest-out/xfstests/xfs/420.out.bad 2022-02-21 08:14:40.000000000 -0500
> @@ -13,9 +13,7 @@
> Seek holes and data in file2
> Whence Result
> DATA 0
> -HOLE 131072
> -DATA 196608
> -HOLE 262144
> +HOLE 524288
> Compare files
> c2803804acc9936eef8aab42c119bfac SCRATCH_MNT/test-420/file1
> 017c08a9320aad844ce86aa9631afb98 SCRATCH_MNT/test-420/file2
> @@ -28,9 +26,7 @@
> Seek holes and data in file2
> Whence Result
> DATA 0
> -HOLE 131072
> -DATA 196608
> -HOLE 262144
> +HOLE 524288
> Compare files
> c2803804acc9936eef8aab42c119bfac SCRATCH_MNT/test-420/file1
> 017c08a9320aad844ce86aa9631afb98 SCRATCH_MNT/test-420/file2
>
> So the file checksums are right, which means I didn't break the COW
> functionality. But we're no longer reporting a hole at 128k.
Can you post the contents of the 420.full output file so we can see
what the output of the various commands that are run are? e.g.
things like cowextsize that is configured, etc?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-02-21 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220221080217.GB835@xsang-OptiPlex-9020>
2022-02-21 13:56 ` [mm/readahead] a0b99df1aa: xfstests.xfs.421.fail Matthew Wilcox
2022-02-21 20:55 ` Dave Chinner [this message]
2022-02-21 21:10 ` Matthew Wilcox
2022-02-21 21:43 ` Dave Chinner
2022-02-23 19:59 ` Matthew Wilcox
2022-02-23 20:19 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221205529.GH59715@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=oliver.sang@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox