From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D441C433FE for ; Wed, 9 Mar 2022 21:25:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234588AbiCIV00 (ORCPT ); Wed, 9 Mar 2022 16:26:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231465AbiCIV0Z (ORCPT ); Wed, 9 Mar 2022 16:26:25 -0500 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8555738F for ; Wed, 9 Mar 2022 13:25:26 -0800 (PST) Received: from dread.disaster.area (pa49-186-150-27.pa.vic.optusnet.com.au [49.186.150.27]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 5F1E953173A; Thu, 10 Mar 2022 08:25:25 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nS3oC-003XNX-NJ; Thu, 10 Mar 2022 08:25:24 +1100 Date: Thu, 10 Mar 2022 08:25:24 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, fdmanana@kernel.org, andrey.zhadchenko@virtuozzo.com, brauner@kernel.org, hch@lst.de Subject: Re: [PATCH 2/2] xfs: refactor user/group quota chown in xfs_setattr_nonsize Message-ID: <20220309212524.GG661808@dread.disaster.area> References: <164685372611.495833.8601145506549093582.stgit@magnolia> <164685373748.495833.4023209082084946055.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164685373748.495833.4023209082084946055.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=62291b45 a=sPqof0Mm7fxWrhYUF33ZaQ==:117 a=sPqof0Mm7fxWrhYUF33ZaQ==:17 a=kj9zAlcOel0A:10 a=o8Y5sQTvuykA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=JuDxSlhT3OO6blO4plAA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Mar 09, 2022 at 11:22:17AM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > Combine if tests to reduce the indentation levels of the quota chown > calls in xfs_setattr_nonsize. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/xfs_iops.c | 60 ++++++++++++++++++----------------------------------- > 1 file changed, 20 insertions(+), 40 deletions(-) Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com