From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: constify the name argument to various directory functions
Date: Thu, 10 Mar 2022 09:06:42 +1100 [thread overview]
Message-ID: <20220309220642.GJ661808@dread.disaster.area> (raw)
In-Reply-To: <164685376173.496011.12006782245730068988.stgit@magnolia>
On Wed, Mar 09, 2022 at 11:22:41AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Various directory functions do not modify their @name parameter,
> so mark it const to make that clear. This will enable us to mark
> the global xfs_name_dotdot variable as const to prevent mischief.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/libxfs/xfs_dir2.c | 12 ++++++------
> fs/xfs/libxfs/xfs_dir2.h | 4 ++--
> fs/xfs/libxfs/xfs_dir2_priv.h | 5 +++--
> 3 files changed, 11 insertions(+), 10 deletions(-)
Looks fine, but I can't help but wonder if you just pulled on a ball
of string...
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-03-09 22:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 19:22 [PATCHSET 0/2] xfs: constify dotdot global variable Darrick J. Wong
2022-03-09 19:22 ` [PATCH 1/2] xfs: constify the name argument to various directory functions Darrick J. Wong
2022-03-09 22:06 ` Dave Chinner [this message]
2022-03-09 19:22 ` [PATCH 2/2] xfs: constify xfs_name_dotdot Darrick J. Wong
2022-03-09 22:32 ` Dave Chinner
2022-03-09 23:27 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2022-03-10 21:53 [PATCHSET v2 0/2] xfs: constify dotdot global variable Darrick J. Wong
2022-03-10 21:53 ` [PATCH 1/2] xfs: constify the name argument to various directory functions Darrick J. Wong
2022-03-10 22:25 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309220642.GJ661808@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox