From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261BDC433EF for ; Wed, 9 Mar 2022 22:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233541AbiCIWHo (ORCPT ); Wed, 9 Mar 2022 17:07:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233630AbiCIWHn (ORCPT ); Wed, 9 Mar 2022 17:07:43 -0500 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2089E11EF3D for ; Wed, 9 Mar 2022 14:06:44 -0800 (PST) Received: from dread.disaster.area (pa49-186-150-27.pa.vic.optusnet.com.au [49.186.150.27]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 6A387531552; Thu, 10 Mar 2022 09:06:43 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nS4SA-003Y3R-S0; Thu, 10 Mar 2022 09:06:42 +1100 Date: Thu, 10 Mar 2022 09:06:42 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/2] xfs: constify the name argument to various directory functions Message-ID: <20220309220642.GJ661808@dread.disaster.area> References: <164685375609.496011.2754821878646256374.stgit@magnolia> <164685376173.496011.12006782245730068988.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164685376173.496011.12006782245730068988.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=622924f3 a=sPqof0Mm7fxWrhYUF33ZaQ==:117 a=sPqof0Mm7fxWrhYUF33ZaQ==:17 a=kj9zAlcOel0A:10 a=o8Y5sQTvuykA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=dj7gh8l4VPkhDtfmg9kA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Mar 09, 2022 at 11:22:41AM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > Various directory functions do not modify their @name parameter, > so mark it const to make that clear. This will enable us to mark > the global xfs_name_dotdot variable as const to prevent mischief. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_dir2.c | 12 ++++++------ > fs/xfs/libxfs/xfs_dir2.h | 4 ++-- > fs/xfs/libxfs/xfs_dir2_priv.h | 5 +++-- > 3 files changed, 11 insertions(+), 10 deletions(-) Looks fine, but I can't help but wonder if you just pulled on a ball of string... Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com