From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: David Dal Ben <dalben@gmail.com>,
Eric Sandeen <esandeen@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: Inconsistent "EXPERIMENTAL online shrink feature in use. Use at your own risk" alert
Date: Thu, 10 Mar 2022 09:37:07 +1100 [thread overview]
Message-ID: <20220309223707.GL661808@dread.disaster.area> (raw)
In-Reply-To: <06ce8d7f-db56-d742-26d4-ced82185ab94@sandeen.net>
On Wed, Mar 09, 2022 at 04:18:54PM -0600, Eric Sandeen wrote:
> On 3/9/22 3:19 PM, Dave Chinner wrote:
> > On Wed, Mar 09, 2022 at 12:22:00PM -0600, Eric Sandeen wrote:
>
> ...
>
> >> I'm wondering if we have some path through xfs_growfs_data_private() that calculates
> >> a delta < 0 unintentionally, or if we get there with delta == 0 and generate the
> >> warning message.
> >
> > Nope, we're not even getting there for the delta == 0 case...
>
> Ok, thanks - I should have checked that.
>
> Soooo how is a no-argument xfs_growfs, with size calculated by the tool based on the
> disk size, failing immediately after a mount? Makes no sense to me.
Remember, unraid is an out of tree MD block device driver, so
there's every chance that XFS is just the messenger telling us that
the device driver has bugs in it's size handling or
discovery/recovery/assembly behaviour. Until we get an actual
command line reproducer for this problem on an in-tree block device,
I would not spend any more time worrying about it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2022-03-09 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALwRca2+UsEZMPwiCtecM87HVVMs27SdawdWXns+PU7+S-DFaQ@mail.gmail.com>
2022-03-07 12:19 ` Inconsistent "EXPERIMENTAL online shrink feature in use. Use at your own risk" alert David Dal Ben
2022-03-07 13:27 ` Gao Xiang
2022-03-07 15:16 ` David Dal Ben
2022-03-07 15:29 ` Eric Sandeen
2022-03-07 22:46 ` David Dal Ben
2022-03-07 23:31 ` Dave Chinner
2022-03-07 23:51 ` Gao Xiang
2022-03-08 0:04 ` David Dal Ben
2022-03-09 18:22 ` Eric Sandeen
2022-03-09 21:19 ` Dave Chinner
2022-03-09 22:18 ` Eric Sandeen
2022-03-09 22:37 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309223707.GL661808@dread.disaster.area \
--to=david@fromorbit.com \
--cc=dalben@gmail.com \
--cc=esandeen@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox