From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, fdmanana@kernel.org,
andrey.zhadchenko@virtuozzo.com, brauner@kernel.org,
david@fromorbit.com, hch@lst.de
Subject: Re: [PATCH 2/2] xfs: refactor user/group quota chown in xfs_setattr_nonsize
Date: Thu, 10 Mar 2022 09:10:04 +0100 [thread overview]
Message-ID: <20220310081004.GB25823@lst.de> (raw)
In-Reply-To: <164685373748.495833.4023209082084946055.stgit@magnolia>
On Wed, Mar 09, 2022 at 11:22:17AM -0800, Darrick J. Wong wrote:
> + if ((mask & ATTR_UID) && XFS_IS_UQUOTA_ON(mp) &&
> + !uid_eq(inode->i_uid, iattr->ia_uid)) {
Nit: I think in this case an indentation like:
if ((mask & ATTR_UID) && XFS_IS_UQUOTA_ON(mp) &&
!uid_eq(inode->i_uid, iattr->ia_uid)) {
is way more readable. Same for the gid case.
Otherwise this looks like a nice cleanup:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-03-10 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 19:22 [PATCHSET 0/2] xfs: use setattr_copy to set VFS file attributes Darrick J. Wong
2022-03-09 19:22 ` [PATCH 1/2] xfs: use setattr_copy to set vfs inode attributes Darrick J. Wong
2022-03-09 21:22 ` Dave Chinner
2022-03-10 8:07 ` Christoph Hellwig
2022-03-10 10:11 ` Christian Brauner
2022-03-10 17:34 ` Darrick J. Wong
2022-03-11 7:54 ` Christian Brauner
2022-03-09 19:22 ` [PATCH 2/2] xfs: refactor user/group quota chown in xfs_setattr_nonsize Darrick J. Wong
2022-03-09 21:25 ` Dave Chinner
2022-03-10 8:10 ` Christoph Hellwig [this message]
2022-03-10 9:59 ` Christian Brauner
2022-03-09 23:01 ` [PATCHSET 0/2] xfs: use setattr_copy to set VFS file attributes Andrey Zhadchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310081004.GB25823@lst.de \
--to=hch@lst.de \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fdmanana@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox