From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81467C433EF for ; Thu, 10 Mar 2022 08:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240221AbiCJILM (ORCPT ); Thu, 10 Mar 2022 03:11:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240222AbiCJILK (ORCPT ); Thu, 10 Mar 2022 03:11:10 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2C091342C1 for ; Thu, 10 Mar 2022 00:10:09 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 6BE9168AFE; Thu, 10 Mar 2022 09:10:05 +0100 (CET) Date: Thu, 10 Mar 2022 09:10:04 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, fdmanana@kernel.org, andrey.zhadchenko@virtuozzo.com, brauner@kernel.org, david@fromorbit.com, hch@lst.de Subject: Re: [PATCH 2/2] xfs: refactor user/group quota chown in xfs_setattr_nonsize Message-ID: <20220310081004.GB25823@lst.de> References: <164685372611.495833.8601145506549093582.stgit@magnolia> <164685373748.495833.4023209082084946055.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164685373748.495833.4023209082084946055.stgit@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Mar 09, 2022 at 11:22:17AM -0800, Darrick J. Wong wrote: > + if ((mask & ATTR_UID) && XFS_IS_UQUOTA_ON(mp) && > + !uid_eq(inode->i_uid, iattr->ia_uid)) { Nit: I think in this case an indentation like: if ((mask & ATTR_UID) && XFS_IS_UQUOTA_ON(mp) && !uid_eq(inode->i_uid, iattr->ia_uid)) { is way more readable. Same for the gid case. Otherwise this looks like a nice cleanup: Reviewed-by: Christoph Hellwig