From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693B5C433EF for ; Thu, 10 Mar 2022 22:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242959AbiCJW1N (ORCPT ); Thu, 10 Mar 2022 17:27:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiCJW1M (ORCPT ); Thu, 10 Mar 2022 17:27:12 -0500 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 931FF15720F for ; Thu, 10 Mar 2022 14:26:11 -0800 (PST) Received: from dread.disaster.area (pa49-186-150-27.pa.vic.optusnet.com.au [49.186.150.27]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id D49DB10E3E9B; Fri, 11 Mar 2022 09:26:10 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nSREY-003x1O-9N; Fri, 11 Mar 2022 09:26:10 +1100 Date: Fri, 11 Mar 2022 09:26:10 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: constify xfs_name_dotdot Message-ID: <20220310222610.GF3927073@dread.disaster.area> References: <164694922267.1119724.17942999738634110525.stgit@magnolia> <164694923383.1119724.11884585401815905581.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164694923383.1119724.11884585401815905581.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=622a7b02 a=sPqof0Mm7fxWrhYUF33ZaQ==:117 a=sPqof0Mm7fxWrhYUF33ZaQ==:17 a=kj9zAlcOel0A:10 a=o8Y5sQTvuykA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=Bgz0Aa6F1li_VknHRpoA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Mar 10, 2022 at 01:53:53PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > The symbol xfs_name_dotdot is a global variable that the xfs codebase > uses here and there to look up directory dotdot entries. Currently it's > a non-const variable, which means that it's a mutable global variable. > So far nobody's abused this to cause problems, but let's use the > compiler to enforce that. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_dir2.c | 6 +++++- > fs/xfs/libxfs/xfs_dir2.h | 2 +- > 2 files changed, 6 insertions(+), 2 deletions(-) Much simpler :) Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com