From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A132C433EF for ; Wed, 23 Mar 2022 21:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241077AbiCWVW6 (ORCPT ); Wed, 23 Mar 2022 17:22:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344888AbiCWVW5 (ORCPT ); Wed, 23 Mar 2022 17:22:57 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F222A8C7FC for ; Wed, 23 Mar 2022 14:21:26 -0700 (PDT) Received: from dread.disaster.area (pa49-186-150-27.pa.vic.optusnet.com.au [49.186.150.27]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 2A11B10E4FDB; Thu, 24 Mar 2022 08:21:26 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nX8Q0-0093XY-87; Thu, 24 Mar 2022 08:21:24 +1100 Date: Thu, 24 Mar 2022 08:21:24 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: Brian Foster , linux-xfs@vger.kernel.org Subject: Re: [PATCH 6/6] xfs: rename "alloc_set_aside" to be more descriptive Message-ID: <20220323212124.GZ1544202@dread.disaster.area> References: <164779460699.550479.5112721232994728564.stgit@magnolia> <164779464063.550479.8986144162552096908.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164779464063.550479.8986144162552096908.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=e9dl9Yl/ c=1 sm=1 tr=0 ts=623b8f56 a=sPqof0Mm7fxWrhYUF33ZaQ==:117 a=sPqof0Mm7fxWrhYUF33ZaQ==:17 a=kj9zAlcOel0A:10 a=o8Y5sQTvuykA:10 a=VwQbUJbxAAAA:8 a=7-415B0cAAAA:8 a=fOmV5-oWONuggIxWm9cA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Mar 20, 2022 at 09:44:00AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > We've established in this patchset that the "alloc_set_aside" pool is > actually used to ensure that a bmbt split always succeeds so that the I don't think this is correct. See my previous comments about the reason for set_aside existing and why I think the bmbt portion of it isn't valid anymore. > filesystem won't run out of space mid-transaction and crash. That's exactly what transaction reservations and args->minleft is for, yes? Cheers, Dave. -- Dave Chinner david@fromorbit.com