From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D7DC433F5 for ; Mon, 28 Mar 2022 01:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234289AbiC1BXi (ORCPT ); Sun, 27 Mar 2022 21:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbiC1BXi (ORCPT ); Sun, 27 Mar 2022 21:23:38 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2797A4F455 for ; Sun, 27 Mar 2022 18:21:59 -0700 (PDT) Received: from dread.disaster.area (pa49-186-150-27.pa.vic.optusnet.com.au [49.186.150.27]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 5E2FC10E65E1; Mon, 28 Mar 2022 12:21:58 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nYe4z-00AiUE-9u; Mon, 28 Mar 2022 12:21:57 +1100 Date: Mon, 28 Mar 2022 12:21:57 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, bfoster@redhat.com Subject: Re: [PATCH 4/6] xfs: always succeed at setting the reserve pool size Message-ID: <20220328012157.GT1544202@dread.disaster.area> References: <164840029642.54920.17464512987764939427.stgit@magnolia> <164840031922.54920.3945394555613593655.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164840031922.54920.3945394555613593655.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=62410db6 a=sPqof0Mm7fxWrhYUF33ZaQ==:117 a=sPqof0Mm7fxWrhYUF33ZaQ==:17 a=kj9zAlcOel0A:10 a=o8Y5sQTvuykA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=GvXJxxrIpZzHQBeqe0UA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Mar 27, 2022 at 09:58:39AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Nowadays, xfs_mod_fdblocks will always choose to fill the reserve pool > with freed blocks before adding to fdblocks. Therefore, we can change > the behavior of xfs_reserve_blocks slightly -- setting the target size > of the pool should always succeed, since a deficiency will eventually > be made up as blocks get freed. > > Signed-off-by: Darrick J. Wong Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com