From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/8] xfs: log shutdown triggers should only shut down the log
Date: Sat, 2 Apr 2022 07:32:31 +1100 [thread overview]
Message-ID: <20220401203231.GK1544202@dread.disaster.area> (raw)
In-Reply-To: <YkbpigVBgtcn3YkX@infradead.org>
On Fri, Apr 01, 2022 at 05:01:14AM -0700, Christoph Hellwig wrote:
> > if (XFS_TEST_ERROR(error, log->l_mp, XFS_ERRTAG_IODONE_IOERR)) {
> > xfs_alert(log->l_mp, "log I/O error %d", error);
> > - xfs_force_shutdown(log->l_mp, SHUTDOWN_LOG_IO_ERROR);
> > + xlog_force_shutdown(log, SHUTDOWN_LOG_IO_ERROR);
>
> The SHUTDOWN_LOG_IO_ERROR as an API to xlog_force_shutdown looks
> really weird now. It s only used to do the xfs_log_force at the
> very beginning of the function. I'd suggest to drop the argument
> and just do that manually in the two callers that do not have
> SHUTDOWN_LOG_IO_ERROR set unconditionally. (This is a perfectly
> fine follow on patch, though).
Yeah, I noticed that as well, but deceided not to do anything about
it as it wasn't directly related to fixing the bugs that I was
tripping over. I think there's a few other cleanups w.r.t. shutdown
error types that can be made, too - I'll get to them when I'm stuck
on hard stuff and need to do somethign realtively easy to keep
things moving...
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks!
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-04-01 20:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 1:10 [PATCH 0/8 v3] xfs: more shutdown/recovery fixes Dave Chinner
2022-03-30 1:10 ` [PATCH 1/8] xfs: aborting inodes on shutdown may need buffer lock Dave Chinner
2022-03-30 1:21 ` Darrick J. Wong
2022-04-01 11:47 ` Christoph Hellwig
2022-04-01 20:35 ` Dave Chinner
2022-03-30 1:10 ` [PATCH 2/8] xfs: shutdown in intent recovery has non-intent items in the AIL Dave Chinner
2022-04-01 11:48 ` Christoph Hellwig
2022-03-30 1:10 ` [PATCH 3/8] xfs: run callbacks before waking waiters in xlog_state_shutdown_callbacks Dave Chinner
2022-04-01 11:51 ` Christoph Hellwig
2022-03-30 1:10 ` [PATCH 4/8] xfs: log shutdown triggers should only shut down the log Dave Chinner
2022-04-01 12:01 ` Christoph Hellwig
2022-04-01 20:32 ` Dave Chinner [this message]
2022-03-30 1:10 ` [PATCH 5/8] xfs: xfs_do_force_shutdown needs to block racing shutdowns Dave Chinner
2022-04-01 12:02 ` Christoph Hellwig
2022-03-30 1:10 ` [PATCH 6/8] xfs: xfs_trans_commit() path must check for log shutdown Dave Chinner
2022-04-01 12:03 ` Christoph Hellwig
2022-03-30 1:10 ` [PATCH 7/8] xfs: shutdown during log recovery needs to mark the " Dave Chinner
2022-04-01 12:05 ` Christoph Hellwig
2022-03-30 1:10 ` [PATCH 8/8] xfs: drop async cache flushes from CIL commits Dave Chinner
2022-04-01 12:06 ` Christoph Hellwig
2022-06-16 22:23 ` Williams, Dan J
2022-06-19 23:40 ` Dave Chinner
2022-06-20 6:14 ` Christoph Hellwig
2022-06-21 23:48 ` Dan Williams
2022-06-23 1:17 ` Dave Chinner
2022-06-23 4:37 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401203231.GK1544202@dread.disaster.area \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).