From: Dave Chinner <david@fromorbit.com>
To: Jonathan Lassoff <jof@thejof.com>
Cc: linux-xfs@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>,
Chris Down <chris@chrisdown.name>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>
Subject: Re: [PATCH v4 1/2] Simplify XFS logging methods.
Date: Mon, 4 Apr 2022 11:40:33 +1000 [thread overview]
Message-ID: <20220404014033.GQ1544202@dread.disaster.area> (raw)
In-Reply-To: <d51e0e0ffc7709010f601ab3c910056379479143.1648690634.git.jof@thejof.com>
On Wed, Mar 30, 2022 at 06:38:05PM -0700, Jonathan Lassoff wrote:
> Rather than have a constructor to define many nearly-identical
> functions, use preprocessor macros to pass down a kernel logging level
> to a common function.
>
> Signed-off-by: Jonathan Lassoff <jof@thejof.com>
> Reviewed-by: Chris Down <chris@chrisdown.name>
Looks good, minor nit below.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
> -#ifdef DEBUG
> -define_xfs_printk_level(xfs_debug, KERN_DEBUG);
> -#endif
> +void
> +xfs_printk_level(
> + const char *kern_level,
> + const struct xfs_mount *mp,
> + const char *fmt, ...)
Whitespace still not quite right. I'll clean that up myself up on
merge, though.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2022-04-04 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 1:38 [PATCH v4 1/2] Simplify XFS logging methods Jonathan Lassoff
2022-03-31 1:38 ` [PATCH v4 2/2] Add XFS messages to printk index Jonathan Lassoff
2022-04-04 1:40 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404014033.GQ1544202@dread.disaster.area \
--to=david@fromorbit.com \
--cc=chris@chrisdown.name \
--cc=djwong@kernel.org \
--cc=jof@thejof.com \
--cc=john.ogness@linutronix.de \
--cc=linux-xfs@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox