From: Dave Chinner <david@fromorbit.com>
To: sandeen@redhat.com
Cc: xfs <linux-xfs@vger.kernel.org>, "Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH V2] mkfs: increase the minimum log size to 64MB when possible
Date: Tue, 5 Apr 2022 15:36:58 +1000 [thread overview]
Message-ID: <20220405053658.GW1544202@dread.disaster.area> (raw)
In-Reply-To: <ac764fd9-ddd9-3b44-02bc-c91c390881c5@redhat.com>
On Mon, Apr 04, 2022 at 06:31:03PM -0500, Eric Sandeen wrote:
> For starters I know the lack of if / else if in the co is a little
> ugly but smashing into 80cols was uglier...
>
> Here are the changes in log size for various filesystem geometries
> (differing block sizes and filesystem sizes, with and without stripe
> geometry to increase AG count). "--" means mkfs failed.
>
> Blocksize: 4096
> | orig | new
> size | log striped | log striped
> -------------------------------------------------------
> 128m | 5m m | 5m m
> 256m | 5m 18m | 5m 18m
> 511m | 5m 18m | 5m 18m
> 512m | 5m 18m | 64m 18m
> 513m | 5m 18m | 64m 64m
> 1024m | 10m 18m | 64m 64m
> 2047m | 10m 18m | 64m 64m
> 2048m | 10m 18m | 64m 64m
> 2049m | 10m 18m | 64m 64m
> 4g | 10m 20m | 64m 64m
> 8g | 10m 20m | 64m 64m
> 15g | 10m 20m | 64m 64m
> 16g | 10m 20m | 64m 64m
> 17g | 10m 20m | 64m 64m
> 32g | 16m 20m | 64m 64m
> 64g | 32m 32m | 64m 64m
> 256g | 128m 128m | 128m 128m
> 512g | 256m 256m | 256m 256m
> 1t | 512m 512m | 512m 512m
> 2t | 1024m 1024m | 1024m 1024m
> 4t | 2038m 2038m | 2038m 2038m
> 8t | 2038m 2038m | 2038m 2038m
>
> Blocksize: 1024
> | orig | new
> size | log striped | log striped
> ------------------------------------------------------------------------------
> 128m | 3m 15m | 3m 15m
> 256m | 3m 15m | 3m 15m
> 511m | 3m 15m | 3m 15m
> 512m | 3m 15m | 64m 15m
> 513m | 3m 15m | 64m 64m
> 1024m | 10m 15m | 64m 64m
> 2047m | 10m 16m | 64m 64m
> 2048m | 10m 16m | 64m 64m
> 2049m | 10m 16m | 64m 64m
> 4g | 10m 16m | 64m 64m
> 8g | 10m 16m | 64m 64m
> 15g | 10m 16m | 64m 64m
> 16g | 10m 16m | 64m 64m
> 17g | 10m 16m | 64m 64m
> 32g | 16m 16m | 64m 64m
> 64g | 32m 32m | 64m 64m
> 256g | 128m 128m | 128m 128m
> 512g | 256m 256m | 256m 256m
> 1t | 512m 512m | 512m 512m
> 2t | 1024m 1024m | 1024m 1024m
> 4t | 1024m 1024m | 1024m 1024m
> 8t | 1024m 1024m | 1024m 1024m
>
> Blocksize: 65536
> | orig | new
> size | log striped | log striped
> ------------------------------------------------------------------------------
> 128m | -- -- | -- --
> 256m | 32m -- | 32m --
> 511m | 32m 32m | 32m 32m
> 512m | 32m 32m | 64m 32m
> 513m | 32m 32m | 64m 63m
> 1024m | 32m 32m | 64m 64m
> 2047m | 56m 45m | 64m 64m
> 2048m | 56m 45m | 64m 64m
> 2049m | 56m 45m | 64m 64m
> 4g | 56m 69m | 64m 69m
> 8g | 56m 69m | 64m 69m
> 15g | 56m 69m | 64m 69m
> 16g | 56m 69m | 64m 69m
> 17g | 56m 69m | 64m 69m
> 32g | 56m 69m | 64m 69m
> 64g | 56m 69m | 64m 69m
> 256g | 128m 128m | 128m 128m
> 512g | 256m 256m | 256m 256m
> 1t | 512m 512m | 512m 512m
> 2t | 1024m 1024m | 1024m 1024m
> 4t | 2038m 2038m | 2038m 2038m
> 8t | 2038m 2038m | 2038m 2038m
Those new sizes look good to me.
Acked-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-04-05 5:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 23:08 [PATCH V2] mkfs: increase the minimum log size to 64MB when possible Eric Sandeen
2022-04-04 23:31 ` Eric Sandeen
2022-04-05 5:36 ` Dave Chinner [this message]
2022-04-05 0:55 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405053658.GW1544202@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox