Re: [PATCH V9 18/19] xfs: Enable bulkstat ioctl to support 64-bit per-inode extent counters

Dave Chinner
2022-04-07T01:43:28Z

On Wed, Apr 06, 2022 at 06:29:12PM -0700, Darrick J. Wong wrote:
> > diff --git a/fs/xfs/xfs_itable.h b/fs/xfs/xfs_itable.h
> > index 2cf3872fcd2f..0150fd53d18e 100644
> > --- a/fs/xfs/xfs_itable.h
> > +++ b/fs/xfs/xfs_itable.h
> > @@ -19,6 +19,8 @@ struct xfs_ibulk {
> > /* Only iterate within the same AG as startino */
> > #define XFS_IBULK_SAME_AG (1 << 0)
> >
> > +#define XFS_IBULK_NREXT64 (1 << 1)
>
> Needs a comment here.
>
> /* Fill out the bs_extents64 field if set. */
> #define XFS_IBULK_NREXT64 (1U << 1)
>
> (Are we supposed to do "1U" now?)

Apparently so. I'm not concerned by this specific patchset right now
because we've got so many unsigned bit fields that need bulk
updates.

I'm slowly working through the ones that are used in__print_flags
macros right now (that'll be 16-17 patches by itself), and once
those are done we can worry about the rest as ongoing individual
cleanups...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com