Re: [PATCH V9.1] xfs: Enable bulkstat ioctl to support 64-bit per-inode extent counters

Dave Chinner
2022-04-11T02:56:11Z

On Sat, Apr 09, 2022 at 07:27:09PM +0530, Chandan Babu R wrote:
> The following changes are made to enable userspace to obtain 64-bit extent
> counters,
> 1. Carve out a new 64-bit field xfs_bulkstat->bs_extents64 from
> xfs_bulkstat->bs_pad[] to hold 64-bit extent counter.
> 2. Define the new flag XFS_BULK_IREQ_BULKSTAT for userspace to indicate that
> it is capable of receiving 64-bit extent counters.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> Suggested-by: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
....
> diff --git a/fs/xfs/xfs_itable.h b/fs/xfs/xfs_itable.h
> index 5ee1d3f44ce9..e2d0eba43f35 100644
> --- a/fs/xfs/xfs_itable.h
> +++ b/fs/xfs/xfs_itable.h
> @@ -19,6 +19,9 @@ struct xfs_ibulk {
> /* Only iterate within the same AG as startino */
> #define XFS_IBULK_SAME_AG (1U << 0)

This doesn't apply - I guess you modified patch 17 to make this 1U
instead of 1 and then didn't resend it.

I'll clean it up....

-Dave.
--
Dave Chinner
david@fromorbit.com