From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9632C433F5 for ; Thu, 7 Apr 2022 01:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236628AbiDGBpX (ORCPT ); Wed, 6 Apr 2022 21:45:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239132AbiDGBol (ORCPT ); Wed, 6 Apr 2022 21:44:41 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 377C61C2334 for ; Wed, 6 Apr 2022 18:42:06 -0700 (PDT) Received: from dread.disaster.area (pa49-186-233-190.pa.vic.optusnet.com.au [49.186.233.190]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 21B1510E5719; Thu, 7 Apr 2022 11:42:05 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1ncH9v-00EflI-LU; Thu, 07 Apr 2022 11:42:03 +1000 Date: Thu, 7 Apr 2022 11:42:03 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Chandan Babu R , linux-xfs@vger.kernel.org, Dave Chinner Subject: Re: [PATCH V9 18/19] xfs: Enable bulkstat ioctl to support 64-bit per-inode extent counters Message-ID: <20220407014203.GH1544202@dread.disaster.area> References: <20220406061904.595597-1-chandan.babu@oracle.com> <20220406061904.595597-19-chandan.babu@oracle.com> <20220407012912.GT27690@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407012912.GT27690@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=e9dl9Yl/ c=1 sm=1 tr=0 ts=624e416d a=bHAvQTfMiaNt/bo4vVGwyA==:117 a=bHAvQTfMiaNt/bo4vVGwyA==:17 a=kj9zAlcOel0A:10 a=z0gMJWrwH1QA:10 a=7-415B0cAAAA:8 a=BC6goKnVEaZnpyYE9XkA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Apr 06, 2022 at 06:29:12PM -0700, Darrick J. Wong wrote: > > diff --git a/fs/xfs/xfs_itable.h b/fs/xfs/xfs_itable.h > > index 2cf3872fcd2f..0150fd53d18e 100644 > > --- a/fs/xfs/xfs_itable.h > > +++ b/fs/xfs/xfs_itable.h > > @@ -19,6 +19,8 @@ struct xfs_ibulk { > > /* Only iterate within the same AG as startino */ > > #define XFS_IBULK_SAME_AG (1 << 0) > > > > +#define XFS_IBULK_NREXT64 (1 << 1) > > Needs a comment here. > > /* Fill out the bs_extents64 field if set. */ > #define XFS_IBULK_NREXT64 (1U << 1) > > (Are we supposed to do "1U" now?) Apparently so. I'm not concerned by this specific patchset right now because we've got so many unsigned bit fields that need bulk updates. I'm slowly working through the ones that are used in__print_flags macros right now (that'll be 16-17 patches by itself), and once those are done we can worry about the rest as ongoing individual cleanups... Cheers, Dave. -- Dave Chinner david@fromorbit.com