Re: [PATCH 2/8] xfs: don't commit the first deferred transaction without intents

[Dave Chinner <david@fromorbit.com>]

On Sun, Apr 10, 2022 at 10:22:48PM -0700, Alli wrote:
> On Tue, 2022-03-15 at 09:06 +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> > 
> > If the first operation in a string of defer ops has no intents,
> > then there is no reason to commit it before running the first call
> > to xfs_defer_finish_one(). This allows the defer ops to be used
> > effectively for non-intent based operations without requiring an
> > unnecessary extra transaction commit when first called.
> > 
> > This fixes a regression in per-attribute modification transaction
> > count when delayed attributes are not being used.
> > 
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> 
> I recall some time ago, you had given me this patch, and I added it to
> the delayed attribute series series.  The reviews created a slightly
> more simplified version of this, so if you are ok with how that one
> turned out, you can just omit this patch from the white out series.  Or
> if you prefer to keep it with this set, you can just adopt the second
> patch of the larp series, and I can omit it from there.  Either was
> should be fine I think?

The version in this patch set is quite different in implementation
scope - the original was just a scatter-gun that checked if the
transaction was not dirty. This one checks if there are intents
being logged, so the conditions under which it skips the commit are
much more refined.

Hence I don't the reviews carry over, and I think the version in the
whiteout patchset is the version we want...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com