Re: [PATCH] xfs: Use generic_file_open()

["Darrick J. Wong" <djwong@kernel.org>]

On Sat, Apr 09, 2022 at 04:52:20PM +0100, Matthew Wilcox (Oracle) wrote:
> Remove the open-coded check of O_LARGEFILE.  This changes the errno
> to be the same as other filesystems; it was changed generically in
> 2.6.24 but that fix skipped XFS.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

LGTM,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_file.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 5bddb1e9e0b3..c5541d062d0d 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -1167,12 +1167,10 @@ xfs_file_open(
>  	struct inode	*inode,
>  	struct file	*file)
>  {
> -	if (!(file->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS)
> -		return -EFBIG;
>  	if (xfs_is_shutdown(XFS_M(inode->i_sb)))
>  		return -EIO;
>  	file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC;
> -	return 0;
> +	return generic_file_open(inode, file);
>  }
>  
>  STATIC int
> -- 
> 2.34.1
>