Re: [PATCH 3/3] xfs/216: handle larger log sizes

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Apr 14, 2022 at 01:44:00AM +0800, Zorro Lang wrote:
> On Mon, Apr 11, 2022 at 03:55:13PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > mkfs will soon refuse to format a log smaller than 64MB, so update this
> > test to reflect the new log sizing calculations.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> >  tests/xfs/216.out |   14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > 
> > diff --git a/tests/xfs/216.out b/tests/xfs/216.out
> > index cbd7b652..3c12085f 100644
> > --- a/tests/xfs/216.out
> > +++ b/tests/xfs/216.out
> > @@ -1,10 +1,10 @@
> >  QA output created by 216
> > -fssize=1g log      =internal log           bsize=4096   blocks=2560, version=2
> > -fssize=2g log      =internal log           bsize=4096   blocks=2560, version=2
> > -fssize=4g log      =internal log           bsize=4096   blocks=2560, version=2
> > -fssize=8g log      =internal log           bsize=4096   blocks=2560, version=2
> > -fssize=16g log      =internal log           bsize=4096   blocks=2560, version=2
> > -fssize=32g log      =internal log           bsize=4096   blocks=4096, version=2
> > -fssize=64g log      =internal log           bsize=4096   blocks=8192, version=2
> > +fssize=1g log      =internal log           bsize=4096   blocks=16384, version=2
> > +fssize=2g log      =internal log           bsize=4096   blocks=16384, version=2
> > +fssize=4g log      =internal log           bsize=4096   blocks=16384, version=2
> > +fssize=8g log      =internal log           bsize=4096   blocks=16384, version=2
> > +fssize=16g log      =internal log           bsize=4096   blocks=16384, version=2
> > +fssize=32g log      =internal log           bsize=4096   blocks=16384, version=2
> > +fssize=64g log      =internal log           bsize=4096   blocks=16384, version=2
> 
> So this will break downstream kernel testing too, except it follows this new
> xfs behavior change. Is it possible to get the minimal log size, then help to
> avoid the failure (if it won't mess up the code:)?

Hmm.  I suppose we could do a .out.XXX switcheroo type thing, though I
don't know of a good way to detect which mkfs behavior you've got.

--D

> 
> >  fssize=128g log      =internal log           bsize=4096   blocks=16384, version=2
> >  fssize=256g log      =internal log           bsize=4096   blocks=32768, version=2
> > 
>