From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01360C433F5 for ; Fri, 22 Apr 2022 22:35:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232882AbiDVWi0 (ORCPT ); Fri, 22 Apr 2022 18:38:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233599AbiDVWhi (ORCPT ); Fri, 22 Apr 2022 18:37:38 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5F60C28CFFC for ; Fri, 22 Apr 2022 14:48:19 -0700 (PDT) Received: from dread.disaster.area (pa49-181-115-138.pa.nsw.optusnet.com.au [49.181.115.138]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id A4DF053451C; Sat, 23 Apr 2022 07:48:18 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1ni18T-003KSy-Cf; Sat, 23 Apr 2022 07:48:17 +1000 Date: Sat, 23 Apr 2022 07:48:17 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/4] xfs: simplify xfs_rmap_lookup_le call sites Message-ID: <20220422214817.GZ1544202@dread.disaster.area> References: <164997683918.383709.10179435130868945685.stgit@magnolia> <164997685075.383709.9161047695879739444.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164997685075.383709.9161047695879739444.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=deDjYVbe c=1 sm=1 tr=0 ts=626322a2 a=/kVtbFzwtM2bJgxRVb+eeA==:117 a=/kVtbFzwtM2bJgxRVb+eeA==:17 a=kj9zAlcOel0A:10 a=z0gMJWrwH1QA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=eq8JXRs6Dps1z5OMOyQA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Apr 14, 2022 at 03:54:10PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Most callers of xfs_rmap_lookup_le will retrieve the btree record > immediately if the lookup succeeds. The overlapped version of this > function (xfs_rmap_lookup_le_range) will return the record if the lookup > succeeds, so make the regular version do it too. Get rid of the useless > len argument, since it's not part of the lookup key. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_rmap.c | 59 +++++++++++++++++----------------------------- > fs/xfs/libxfs/xfs_rmap.h | 4 ++- > fs/xfs/scrub/bmap.c | 24 +++---------------- > 3 files changed, 28 insertions(+), 59 deletions(-) Nice cleanup. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com