Re: [PATCH 3/8] xfs: add log item flags to indicate intents

Christoph Hellwig
2022-04-28T13:04:49Z

On Tue, Apr 26, 2022 at 08:04:39PM -0700, Darrick J. Wong wrote:
> > We need to be able to identify intent and intent done items quickly
> > and easily in upcoming patches, so simply add intent and intent done
> > type flags to the log item ops flags. These are static flags to
> > begin with, so intent items should have been typed like this from
> > the start.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
>
> Heh, I remember being told to infer intentness or intentdoneness instead
> of using explicit flags...
>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

And I still think having this information redundant and not inferred
seems like a bad move. But I'll scan the following patchs to see if
there is a good rationale for it, because based on this patch alone
it doesn't actually seem like a good idea to me.