From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/4] xfs: set XFS_FEAT_NLINK correctly
Date: Tue, 3 May 2022 15:55:58 -0700 [thread overview]
Message-ID: <20220503225558.GH8265@magnolia> (raw)
In-Reply-To: <20220502082018.1076561-4-david@fromorbit.com>
On Mon, May 02, 2022 at 06:20:17PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> While xfs_has_nlink() is not used in kernel, it is used in userspace
> (e.g. by xfs_db) so we need to set the XFS_FEAT_NLINK flag correctly
> in xfs_sb_version_to_features().
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Oops
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_sb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
> index cf9e5b9374c1..ec6eec5c0e02 100644
> --- a/fs/xfs/libxfs/xfs_sb.c
> +++ b/fs/xfs/libxfs/xfs_sb.c
> @@ -70,6 +70,8 @@ xfs_sb_version_to_features(
> /* optional V4 features */
> if (sbp->sb_rblocks > 0)
> features |= XFS_FEAT_REALTIME;
> + if (sbp->sb_versionnum & XFS_SB_VERSION_NLINKBIT)
> + features |= XFS_FEAT_NLINK;
> if (sbp->sb_versionnum & XFS_SB_VERSION_ATTRBIT)
> features |= XFS_FEAT_ATTR;
> if (sbp->sb_versionnum & XFS_SB_VERSION_QUOTABIT)
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-05-03 22:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 8:20 [PATCH 0/4] xfs: fix random format verification issues Dave Chinner
2022-05-02 8:20 ` [PATCH 1/4] xfs: detect self referencing btree sibling pointers Dave Chinner
2022-05-03 14:53 ` Christoph Hellwig
2022-05-03 21:27 ` Dave Chinner
2022-05-03 22:53 ` Darrick J. Wong
2022-05-03 23:13 ` Dave Chinner
2022-05-06 9:22 ` [xfs] 32678f1513: aim7.jobs-per-min -5.6% regression kernel test robot
2022-05-06 21:29 ` Dave Chinner
2022-05-07 11:09 ` [LKP] " Carel Si
2022-05-09 0:03 ` Dave Chinner
2022-05-02 8:20 ` [PATCH 2/4] xfs: validate inode fork size against fork format Dave Chinner
2022-05-03 14:55 ` Christoph Hellwig
2022-05-03 22:55 ` Darrick J. Wong
2022-05-02 8:20 ` [PATCH 3/4] xfs: set XFS_FEAT_NLINK correctly Dave Chinner
2022-05-03 14:56 ` Christoph Hellwig
2022-05-03 22:55 ` Darrick J. Wong [this message]
2022-05-02 8:20 ` [PATCH 4/4] xfs: validate v5 feature fields Dave Chinner
2022-05-02 9:44 ` kernel test robot
2022-05-02 12:37 ` kernel test robot
2022-05-03 15:00 ` Christoph Hellwig
2022-05-03 21:26 ` Dave Chinner
2022-05-03 22:59 ` Darrick J. Wong
2022-05-03 23:18 ` Dave Chinner
2022-05-03 23:28 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503225558.GH8265@magnolia \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox