From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Amir Goldstein <amir73il@gmail.com>,
Dave Chinner <david@fromorbit.com>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [QUESTION] Upgrade xfs filesystem to reflink support?
Date: Tue, 10 May 2022 11:54:37 -0700 [thread overview]
Message-ID: <20220510185437.GB27195@magnolia> (raw)
In-Reply-To: <Ynowf/rmU2UVPlqw@infradead.org>
On Tue, May 10, 2022 at 02:29:35AM -0700, Christoph Hellwig wrote:
> On Mon, May 09, 2022 at 11:20:43AM -0700, Darrick J. Wong wrote:
> > > Is there any a priori NACK or exceptional challenges w.r.t implementing
> > > upgrade of xfs to reflink support?
> >
> > No, just lack of immediate user demand + time to develop and merge code
> > + time to QA the whole mess to make sure it doesn't introduce any
> > messes.
>
> I also have vague memory I did an in-kernel online upgrade back in the
> day but we decided to not bother in the end. Maybe some list archive
> search could find it.
https://lore.kernel.org/linux-xfs/1464877150-20457-1-git-send-email-hch@lst.de/
Note that your version did live upgrades of mounted filesystems
whereas the one I wrote does it as part of xfs_repair, which means we
have a somewhat better guarantee that the fs will be in decent shape
afterwards.
--D
prev parent reply other threads:[~2022-05-10 18:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 7:50 [QUESTION] Upgrade xfs filesystem to reflink support? Amir Goldstein
2022-05-09 18:20 ` Darrick J. Wong
2022-05-10 6:21 ` Amir Goldstein
2022-05-10 19:02 ` Darrick J. Wong
2022-05-10 22:05 ` Dave Chinner
2022-05-11 15:46 ` Brian Foster
2022-05-11 22:24 ` Dave Chinner
2022-05-16 13:35 ` Brian Foster
2022-05-17 9:30 ` Dave Chinner
2022-05-19 16:07 ` Brian Foster
2022-05-19 23:05 ` Dave Chinner
2022-05-10 9:29 ` Christoph Hellwig
2022-05-10 18:54 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510185437.GB27195@magnolia \
--to=djwong@kernel.org \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox