From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/4] xfs_repair: check free rt extent count
Date: Tue, 10 May 2022 17:07:46 -0700 [thread overview]
Message-ID: <20220511000746.GZ27195@magnolia> (raw)
In-Reply-To: <Ynpf+KLA1jD6P5vF@infradead.org>
On Tue, May 10, 2022 at 05:52:08AM -0700, Christoph Hellwig wrote:
> On Thu, May 05, 2022 at 09:04:54AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Check the superblock's free rt extent count against what we observed.
> > This increases the runtime and memory usage, but we can now report
> > undercounting frextents as a result of a logging bug in the kernel.
> > Note that repair has always fixed the undercount, but it no longer does
> > that silently.
>
> This looks sensible, but can't we still skip running phase5 for
> file systems without an RT subvolume?
Yeah, I was of half a mind to make a separate function phase5_nomodify
instead of burying that in phase5_func()...
...but OTOH, I suppose the dinode inspection functions will flag errors
if the superblock says sb_rextents == 0 but DIFLAG_REALTIME is set on a
regular file. So, I guess that could be a separate check_rtmetadata()
function that lives inside phase5.c and gets triggered in the
(nomodify && sb_rblocks > 0) case.
--D
next prev parent reply other threads:[~2022-05-11 0:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 16:04 [PATCHSET 0/4] xfs_repair: check rt bitmap and summary Darrick J. Wong
2022-05-05 16:04 ` [PATCH 1/4] xfs_repair: fix sizing of the incore rt space usage map calculation Darrick J. Wong
2022-05-10 12:51 ` Christoph Hellwig
2022-05-05 16:04 ` [PATCH 2/4] xfs_repair: check free rt extent count Darrick J. Wong
2022-05-10 12:52 ` Christoph Hellwig
2022-05-11 0:07 ` Darrick J. Wong [this message]
2022-05-05 16:04 ` [PATCH 3/4] xfs_repair: check the rt bitmap against observations Darrick J. Wong
2022-05-10 12:53 ` Christoph Hellwig
2022-05-05 16:05 ` [PATCH 4/4] xfs_repair: check the rt summary " Darrick J. Wong
2022-05-10 12:54 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2022-05-13 20:33 [PATCHSET v2 0/4] xfs_repair: check rt bitmap and summary Darrick J. Wong
2022-05-13 20:34 ` [PATCH 2/4] xfs_repair: check free rt extent count Darrick J. Wong
2022-05-16 9:43 ` Chandan Babu R
2022-05-16 13:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511000746.GZ27195@magnolia \
--to=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox