From: "Darrick J. Wong" <djwong@kernel.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs_repair: detect v5 featureset mismatches in secondary supers
Date: Thu, 12 May 2022 12:13:29 -0700 [thread overview]
Message-ID: <20220512191329.GH27195@magnolia> (raw)
In-Reply-To: <57914c5f-c39a-e3de-14cf-6565ee82f834@redhat.com>
On Thu, May 12, 2022 at 02:02:33PM -0500, Eric Sandeen wrote:
> On 5/5/22 11:05 AM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Make sure we detect and correct mismatches between the V5 features
> > described in the primary and the secondary superblocks.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
>
>
> > + if ((mp->m_sb.sb_features_incompat ^ sb->sb_features_incompat) &
> > + ~XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR) {
>
> I'd like to add a comment about why XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR is special.
> (Why is XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR special? Just because userspace doesn't
> bother to set it on all superblocks in the upgrade paths, right?)
Right -- we only set it on the primary super to force users to run
xfs_repair. Repair will clear NEEDSREPAIR on the primary and all
secondaries before it exits, so there's no point in complaining about
discrepancies in that particular feature bit.
--D
> -Eric
>
next prev parent reply other threads:[~2022-05-12 19:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 16:05 [PATCHSET 0/3] xfs_repair: various small fixes Darrick J. Wong
2022-05-05 16:05 ` [PATCH 1/3] xfs_repair: detect v5 featureset mismatches in secondary supers Darrick J. Wong
2022-05-12 19:02 ` Eric Sandeen
2022-05-12 19:13 ` Darrick J. Wong [this message]
2022-05-16 8:11 ` Dave Chinner
2022-05-16 17:59 ` Darrick J. Wong
2022-05-05 16:05 ` [PATCH 2/3] xfs_repair: improve checking of existing rmap and refcount btrees Darrick J. Wong
2022-05-12 19:39 ` Eric Sandeen
2022-05-12 20:54 ` Darrick J. Wong
2022-05-05 16:06 ` [PATCH 3/3] xfs_repair: check the ftype of dot and dotdot directory entries Darrick J. Wong
2022-05-12 20:36 ` Eric Sandeen
2022-05-16 18:11 ` [PATCH 4/3] xfs_repair: always rewrite secondary supers when needsrepair is set Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512191329.GH27195@magnolia \
--to=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox