From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF211C433F5 for ; Thu, 19 May 2022 01:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230513AbiESBhB (ORCPT ); Wed, 18 May 2022 21:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232496AbiESBhA (ORCPT ); Wed, 18 May 2022 21:37:00 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5ADB995DF6 for ; Wed, 18 May 2022 18:36:58 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 9B901534512; Thu, 19 May 2022 11:36:57 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nrV60-00DfhX-0U; Thu, 19 May 2022 11:36:56 +1000 Date: Thu, 19 May 2022 11:36:56 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, allison.henderson@oracle.com Subject: Re: [PATCH 1/3] xfs: validate xattr name earlier in recovery Message-ID: <20220519013656.GT1098723@dread.disaster.area> References: <165290010248.1646163.12346986876716116665.stgit@magnolia> <165290010814.1646163.10353057311329638248.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165290010814.1646163.10353057311329638248.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=62859f39 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=oZkIemNP1mAA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=sqgUYx38-QfSoOeRrZEA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, May 18, 2022 at 11:55:08AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > When we're validating a recovered xattr log item during log recovery, we > should check the name before starting to allocate resources. This isn't > strictly necessary on its own, but it means that we won't bother with > huge memory allocations during recovery if the attr name is garbage, > which will simplify the changes in the next patch. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/xfs_attr_item.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com