From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C429DC433F5 for ; Thu, 19 May 2022 01:37:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232504AbiESBhR (ORCPT ); Wed, 18 May 2022 21:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232506AbiESBhP (ORCPT ); Wed, 18 May 2022 21:37:15 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 442D56540D for ; Wed, 18 May 2022 18:37:13 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 21DB810E64C1; Thu, 19 May 2022 11:37:13 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nrV6F-00DfiE-Fy; Thu, 19 May 2022 11:37:11 +1000 Date: Thu, 19 May 2022 11:37:11 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, allison.henderson@oracle.com Subject: Re: [PATCH 3/3] xfs: free xfs_attrd_log_items correctly Message-ID: <20220519013711.GU1098723@dread.disaster.area> References: <165290010248.1646163.12346986876716116665.stgit@magnolia> <165290011952.1646163.16695840263373472236.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165290011952.1646163.16695840263373472236.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=deDjYVbe c=1 sm=1 tr=0 ts=62859f49 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=oZkIemNP1mAA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=PItcRFfGJKCfdiIialgA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, May 18, 2022 at 11:55:19AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Technically speaking, objects allocated out of a specific slab cache are > supposed to be freed to that slab cache. The popular slab backends will > take care of this for us, but SLOB famously doesn't. Fix this, even if > slob + xfs are not that common of a combination. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/xfs_attr_item.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com