From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 359AFC433F5 for ; Fri, 20 May 2022 03:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345180AbiETDmt (ORCPT ); Thu, 19 May 2022 23:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344284AbiETDms (ORCPT ); Thu, 19 May 2022 23:42:48 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AE7001D0CC for ; Thu, 19 May 2022 20:42:46 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id F277B10E67E2; Fri, 20 May 2022 13:42:45 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nrtXI-00E6Tj-T8; Fri, 20 May 2022 13:42:44 +1000 Date: Fri, 20 May 2022 13:42:44 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, allison.henderson@oracle.com Subject: Re: [PATCH 2/7] xfs: put the xattr intent item op flags in their own namespace Message-ID: <20220520034244.GE1098723@dread.disaster.area> References: <165290014409.1647637.4876706578208264219.stgit@magnolia> <165290015553.1647637.9536028316314201783.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165290015553.1647637.9536028316314201783.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=62870e36 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=oZkIemNP1mAA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=XmSkmimJG3mLJbmEhLsA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, May 18, 2022 at 11:55:55AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > The flags that are stored in the extended attr intent log item really > should have a separate namespace from the rest of the XFS_ATTR_* flags. > Give them one to make it a little more obvious that they're intent item > flags. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_attr.c | 6 +++--- > fs/xfs/libxfs/xfs_attr.h | 2 +- > fs/xfs/libxfs/xfs_log_format.h | 8 ++++---- > fs/xfs/xfs_attr_item.c | 20 ++++++++++---------- > 4 files changed, 18 insertions(+), 18 deletions(-) Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com