Re: [PATCH 3/7] xfs: use a separate slab cache for deferred xattr work state

Dave Chinner
2022-05-20T03:51:06Z

On Wed, May 18, 2022 at 11:56:01AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Create a separate slab cache for struct xfs_attr_item objects, since we
> can pack the (104-byte) intent items more tightly than we can with the
> general slab cache objects. On x86, this means 39 intents per memory
> page instead of 32.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> fs/xfs/libxfs/xfs_attr.c | 20 +++++++++++++++++++-
> fs/xfs/libxfs/xfs_attr.h | 4 ++++
> fs/xfs/libxfs/xfs_defer.c | 4 ++++
> fs/xfs/xfs_attr_item.c | 5 ++++-
> 4 files changed, 31 insertions(+), 2 deletions(-)

Looks ok.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com