From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, allison.henderson@oracle.com
Subject: Re: [PATCH 2/4] xfs: do not use logged xattr updates on V4 filesystems
Date: Mon, 23 May 2022 15:51:52 +1000 [thread overview]
Message-ID: <20220523055152.GR1098723@dread.disaster.area> (raw)
In-Reply-To: <165323327816.78754.11662775390499512627.stgit@magnolia>
On Sun, May 22, 2022 at 08:27:58AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> V4 superblocks do not contain the log_incompat feature bit, which means
> that we cannot protect xattr log items against kernels that are too old
> to know how to recover them. Turn off the log items for such
> filesystems and adjust the "delayed" name to reflect what it's really
> controlling.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/libxfs/xfs_attr.c | 6 +++---
> fs/xfs/libxfs/xfs_attr.h | 3 ++-
> 2 files changed, 5 insertions(+), 4 deletions(-)
looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-05-23 5:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 15:27 [PATCHSET 0/4] xfs: last bit of LARP and other fixes for 5.19 Darrick J. Wong
2022-05-22 15:27 ` [PATCH 1/4] xfs: purge dquots after inode walk fails during quotacheck Darrick J. Wong
2022-05-22 15:27 ` [PATCH 2/4] xfs: do not use logged xattr updates on V4 filesystems Darrick J. Wong
2022-05-23 5:51 ` Dave Chinner [this message]
2022-05-22 15:28 ` [PATCH 3/4] xfs: share xattr name and value buffers when logging xattr updates Darrick J. Wong
2022-05-23 5:59 ` Dave Chinner
2022-05-22 15:28 ` [PATCH 4/4] xfs: allow ->create_intent to return negative errnos Darrick J. Wong
2022-05-22 22:59 ` [PATCHSET 0/4] xfs: last bit of LARP and other fixes for 5.19 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523055152.GR1098723@dread.disaster.area \
--to=david@fromorbit.com \
--cc=allison.henderson@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox