From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3B1C433F5 for ; Fri, 27 May 2022 01:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229741AbiE0B0C (ORCPT ); Thu, 26 May 2022 21:26:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232051AbiE0B0B (ORCPT ); Thu, 26 May 2022 21:26:01 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E23BD5DA43 for ; Thu, 26 May 2022 18:25:59 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 2BE4353457D; Fri, 27 May 2022 11:25:59 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nuOjl-00Gq6J-U2; Fri, 27 May 2022 11:25:57 +1000 Date: Fri, 27 May 2022 11:25:57 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/3] xfs: convert buf_cancel_table allocation to kmalloc_array Message-ID: <20220527012557.GN1098723@dread.disaster.area> References: <165337054460.992964.11039203493792530929.stgit@magnolia> <165337056157.992964.12304312171548323321.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165337056157.992964.12304312171548323321.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=e9dl9Yl/ c=1 sm=1 tr=0 ts=629028a7 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=oZkIemNP1mAA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=y7z1Cq-l73lf6EgP7NUA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, May 23, 2022 at 10:36:01PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > While we're messing around with how recovery allocates and frees the > buffer cancellation table, convert the allocation to use kmalloc_array > instead of the old kmem_alloc APIs, and make it handle a null return, > even though that's not likely. > > Signed-off-by: Darrick J. Wong > Reviewed-by: Christoph Hellwig > --- > fs/xfs/libxfs/xfs_log_recover.h | 2 +- > fs/xfs/xfs_buf_item_recover.c | 14 ++++++++++---- > fs/xfs/xfs_log_recover.c | 4 +++- > 3 files changed, 14 insertions(+), 6 deletions(-) Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com