From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Chandan Babu R <chandanrlinux@gmail.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: preserve DIFLAG2_NREXT64 when setting other inode attributes
Date: Mon, 6 Jun 2022 08:29:40 +1000 [thread overview]
Message-ID: <20220605222940.GL1098723@dread.disaster.area> (raw)
In-Reply-To: <YpzbX/5sgRIcN2LC@magnolia>
On Sun, Jun 05, 2022 at 09:35:43AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> It is vitally important that we preserve the state of the NREXT64 inode
> flag when we're changing the other flags2 fields.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_ioctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Fixes tag?
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 5a364a7d58fd..0d67ff8a8961 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -1096,7 +1096,8 @@ xfs_flags2diflags2(
> {
> uint64_t di_flags2 =
> (ip->i_diflags2 & (XFS_DIFLAG2_REFLINK |
> - XFS_DIFLAG2_BIGTIME));
> + XFS_DIFLAG2_BIGTIME |
> + XFS_DIFLAG2_NREXT64));
>
> if (xflags & FS_XFLAG_DAX)
> di_flags2 |= XFS_DIFLAG2_DAX;
Otherwise looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-06-05 22:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 16:35 [PATCH] xfs: preserve DIFLAG2_NREXT64 when setting other inode attributes Darrick J. Wong
2022-06-05 22:29 ` Dave Chinner [this message]
2022-06-06 0:02 ` Darrick J. Wong
2022-06-06 1:20 ` Dave Chinner
2022-06-06 7:22 ` Amir Goldstein
2022-06-06 17:12 ` Darrick J. Wong
2022-06-07 6:48 ` Amir Goldstein
2022-06-06 12:49 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220605222940.GL1098723@dread.disaster.area \
--to=david@fromorbit.com \
--cc=chandanrlinux@gmail.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox