From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87501C433EF for ; Sun, 5 Jun 2022 22:29:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351689AbiFEW3n (ORCPT ); Sun, 5 Jun 2022 18:29:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348226AbiFEW3n (ORCPT ); Sun, 5 Jun 2022 18:29:43 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 473E037A3D for ; Sun, 5 Jun 2022 15:29:42 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 848595EC9AB; Mon, 6 Jun 2022 08:29:41 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1nxyke-0038n4-Im; Mon, 06 Jun 2022 08:29:40 +1000 Date: Mon, 6 Jun 2022 08:29:40 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Chandan Babu R , xfs Subject: Re: [PATCH] xfs: preserve DIFLAG2_NREXT64 when setting other inode attributes Message-ID: <20220605222940.GL1098723@dread.disaster.area> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=e9dl9Yl/ c=1 sm=1 tr=0 ts=629d2e55 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=JPEYwPQDsx4A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=YGZcs8h0gQ-FCjlu13kA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Jun 05, 2022 at 09:35:43AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > It is vitally important that we preserve the state of the NREXT64 inode > flag when we're changing the other flags2 fields. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/xfs_ioctl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Fixes tag? > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c > index 5a364a7d58fd..0d67ff8a8961 100644 > --- a/fs/xfs/xfs_ioctl.c > +++ b/fs/xfs/xfs_ioctl.c > @@ -1096,7 +1096,8 @@ xfs_flags2diflags2( > { > uint64_t di_flags2 = > (ip->i_diflags2 & (XFS_DIFLAG2_REFLINK | > - XFS_DIFLAG2_BIGTIME)); > + XFS_DIFLAG2_BIGTIME | > + XFS_DIFLAG2_NREXT64)); > > if (xflags & FS_XFLAG_DAX) > di_flags2 |= XFS_DIFLAG2_DAX; Otherwise looks good. Reviewed-by: Dave Chinner -Dave. -- Dave Chinner david@fromorbit.com