Re: [PATCH 5.10 v2 8/8] xfs: assert in xfs_btree_del_cursor should take into account error

Dave Chinner
2022-06-06T21:30:49Z

On Mon, Jun 06, 2022 at 05:32:55PM +0300, Amir Goldstein wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> commit 56486f307100e8fc66efa2ebd8a71941fa10bf6f upstream.
>
> xfs/538 on a 1kB block filesystem failed with this assert:
>
> XFS: Assertion failed: cur->bc_btnum != XFS_BTNUM_BMAP || cur->bc_ino.allocated == 0 || xfs_is_shutdown(cur->bc_mp), file: fs/xfs/libxfs/xfs_btree.c, line: 448

You haven't mentioned that you combined a second upstream
commit into this patch to fix the bug in this commit.....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com