From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J . Wong" <djwong@kernel.org>
Cc: Dave Chinner <david@fromorbit.com>,
Brian Foster <bfoster@redhat.com>, Christoph Hellwig <hch@lst.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org,
Chandan Babu R <chandanrlinux@gmail.com>
Subject: [PATCH 5.10 CANDIDATE 7/7] xfs: fix xfs_reflink_unshare usage of filemap_write_and_wait_range
Date: Mon, 6 Jun 2022 19:05:37 +0300 [thread overview]
Message-ID: <20220606160537.689915-8-amir73il@gmail.com> (raw)
In-Reply-To: <20220606160537.689915-1-amir73il@gmail.com>
From: "Darrick J. Wong" <djwong@kernel.org>
commit d4f74e162d238ce00a640af5f0611c3f51dad70e upstream.
The final parameter of filemap_write_and_wait_range is the end of the
range to flush, not the length of the range to flush.
Fixes: 46afb0628b86 ("xfs: only flush the unshared range in xfs_reflink_unshare")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
fs/xfs/xfs_reflink.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
index 6fa05fb78189..aa46b75d75af 100644
--- a/fs/xfs/xfs_reflink.c
+++ b/fs/xfs/xfs_reflink.c
@@ -1503,7 +1503,8 @@ xfs_reflink_unshare(
if (error)
goto out;
- error = filemap_write_and_wait_range(inode->i_mapping, offset, len);
+ error = filemap_write_and_wait_range(inode->i_mapping, offset,
+ offset + len - 1);
if (error)
goto out;
--
2.25.1
prev parent reply other threads:[~2022-06-06 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 16:05 [PATCH 5.10 CANDIDATE 0/7] xfs stable candidate patches for 5.10.y (part 3) Amir Goldstein
2022-06-06 16:05 ` [PATCH 5.10 CANDIDATE 1/7] xfs: use current->journal_info for detecting transaction recursion Amir Goldstein
2022-06-06 16:05 ` [PATCH 5.10 CANDIDATE 2/7] xfs: rename variable mp to parsing_mp Amir Goldstein
2022-06-06 16:05 ` [PATCH 5.10 CANDIDATE 3/7] xfs: Skip repetitive warnings about mount options Amir Goldstein
2022-06-06 16:05 ` [PATCH 5.10 CANDIDATE 4/7] xfs: ensure xfs_errortag_random_default matches XFS_ERRTAG_MAX Amir Goldstein
2022-06-06 16:05 ` [PATCH 5.10 CANDIDATE 5/7] xfs: fix xfs_trans slab cache name Amir Goldstein
2022-06-06 16:05 ` [PATCH 5.10 CANDIDATE 6/7] xfs: update superblock counters correctly for !lazysbcount Amir Goldstein
2022-06-06 16:05 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220606160537.689915-8-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=a.manzanares@samsung.com \
--cc=bfoster@redhat.com \
--cc=chandanrlinux@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox