Re: [PATCH 01/50] xfs: make last AG grow/shrink perag centric

Christoph Hellwig
2022-06-16T07:30:36Z

On Sat, Jun 11, 2022 at 11:26:10AM +1000, Dave Chinner wrote:
> + error = xfs_ialloc_check_shrink(*tpp, pag->pag_agno, agibp, aglen - delta);

Overly long line here.

> + error = xfs_ialloc_read_agi(pag->pag_mount, NULL, pag->pag_agno, &agi_bp);
> if (error)
> return error;
> - error = xfs_alloc_read_agf(mp, NULL, agno, 0, &agf_bp);
> + error = xfs_alloc_read_agf(pag->pag_mount, NULL, pag->pag_agno, 0, &agf_bp);

.. and two more here

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>