Re: [PATCH 5.10 CANDIDATE 00/11] xfs stable candidate patches for 5.10.y (v5.15+)

Darrick J. Wong
2022-06-22T23:45:34Z

On Fri, Jun 17, 2022 at 01:06:30PM +0300, Amir Goldstein wrote:
> Hi all,
>
> Previously posted candidates for 5.10.y followed chronological release
> order.
>
> Parts 1 and 2 of fixes from v5.10..v5.12 have already been applied to
> v5.10.121.
>
> Part 3 (from 5.13) has already been posted for review [3] on June 6,
> but following feedback from Dave, I changed my focus to get the same
> set of patches tested and reviewed for 5.10.y/5.15.y.
>
> I do want to ask you guys to also find time to review part 3, because
> we have a lot of catching up to do for 5.10.y, so we need to chew at
> this debt at a reasonable rate.
>
> This post has the matching set of patches for 5.10.y that goes with
> Leah's first set of candidates for 5.15.y [1].
>
> Most of the fixes are from v5.15..v5.17 except for patch 11 (v5.18-rc1).
> All fix patches have been tagged with Fixes: by the author.
>
> The patches have been soaking in kdepops since Sunday. They passed more
> than 30 auto group runs with several different versions of xfsprogs.
>
> The differences from Leah's 5.15.y:
> - It is 11 patches and not 8 because of dependencies
> - Patches 6,7 are non-fixes backported as dependency to patch 8 -
> they have "backported .* for dependency" in their commit message
> - Patches 3,4,11 needed changes to apply to 5.10.y - they have a
> "backport" related comment in their commit message to explain what
> changes were needed
> - Patch 10 is a fix from v5.12 that is re-posted as a dependency for
> patch 11
>
> Darrick,
>
> As the author patches 4,11 and sole reviewer of patch 3 (a.k.a
> the non-cleanly applied patches), please take a closer look at those.
>
> Patch 10 has been dropped from my part 2 candidates following concerns
> raised by Dave and is now being re-posted following feedback from
> Christian and Christoph [2].
>
> If there are still concerns about patches 10 or 11, please raise a flag.
> I can drop either of these patches before posting to stable if anyone
> feels that they need more time to soak in master.

At the current moment (keep in mind that I have 2,978 more emails to get
through before I'm caught up), I think it's safe to say that for patches
1-5:

Acked-by: Darrick J. Wong <djwong@kernel.org>

(patch 9 also, but see the reply I just sent for that one about grabbing
the sync_fs fixes too)

The log changes are going to take more time to go through, since that
stuff is always tricky and /not/ something for me to be messing with at
4:45pm.

--D

> Thanks,
> Amir.
>
> [1] https://lore.kernel.org/linux-xfs/20220616182749.1200971-1-leah.rumancik@gmail.com/
> [2] https://lore.kernel.org/linux-xfs/CAOQ4uxg4=m9zEFbDAKXx7CP7HYiMwtsYSJvq076oKpy-OhK1uw@mail.gmail.com/
> [3] https://lore.kernel.org/linux-xfs/20220606160537.689915-1-amir73il@gmail.com/
>
> Brian Foster (1):
> xfs: punch out data fork delalloc blocks on COW writeback failure
>
> Christoph Hellwig (2):
> xfs: refactor xfs_file_fsync
> xfs: fix up non-directory creation in SGID directories
>
> Darrick J. Wong (4):
> xfs: remove all COW fork extents when remounting readonly
> xfs: prevent UAF in xfs_log_item_in_current_chkpt
> xfs: only bother with sync_filesystem during readonly remount
> xfs: use setattr_copy to set vfs inode attributes
>
> Dave Chinner (2):
> xfs: check sb_meta_uuid for dabuf buffer recovery
> xfs: xfs_log_force_lsn isn't passed a LSN
>
> Rustam Kovhaev (1):
> xfs: use kmem_cache_free() for kmem_cache objects
>
> Yang Xu (1):
> xfs: Fix the free logic of state in xfs_attr_node_hasname
>
> fs/xfs/libxfs/xfs_attr.c | 13 +++---
> fs/xfs/libxfs/xfs_types.h | 1 +
> fs/xfs/xfs_aops.c | 15 +++++--
> fs/xfs/xfs_buf_item.c | 2 +-
> fs/xfs/xfs_buf_item_recover.c | 2 +-
> fs/xfs/xfs_dquot_item.c | 2 +-
> fs/xfs/xfs_extfree_item.c | 6 +--
> fs/xfs/xfs_file.c | 81 +++++++++++++++++++++--------------
> fs/xfs/xfs_inode.c | 24 +++++------
> fs/xfs/xfs_inode_item.c | 4 +-
> fs/xfs/xfs_inode_item.h | 2 +-
> fs/xfs/xfs_iops.c | 56 ++----------------------
> fs/xfs/xfs_log.c | 27 ++++++------
> fs/xfs/xfs_log.h | 4 +-
> fs/xfs/xfs_log_cil.c | 32 ++++++--------
> fs/xfs/xfs_log_priv.h | 15 +++----
> fs/xfs/xfs_pnfs.c | 3 +-
> fs/xfs/xfs_super.c | 21 ++++++---
> fs/xfs/xfs_trans.c | 6 +--
> fs/xfs/xfs_trans.h | 4 +-
> 20 files changed, 149 insertions(+), 171 deletions(-)
>
> --
> 2.25.1
>