From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E5DC433EF for ; Thu, 23 Jun 2022 23:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbiFWXNZ (ORCPT ); Thu, 23 Jun 2022 19:13:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbiFWXNW (ORCPT ); Thu, 23 Jun 2022 19:13:22 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DA52F2EA1D for ; Thu, 23 Jun 2022 16:13:20 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id E1F0C5ECF41; Fri, 24 Jun 2022 09:13:19 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1o4W0k-00AH8p-Rf; Fri, 24 Jun 2022 09:13:18 +1000 Date: Fri, 24 Jun 2022 09:13:18 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, allison.henderson@oracle.com Subject: Re: [PATCH 2/2] xfs: clean up the end of xfs_attri_item_recover Message-ID: <20220623231318.GW227878@dread.disaster.area> References: <165601679540.2928801.11814839944987662641.stgit@magnolia> <165601680672.2928801.4056935562404690211.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165601680672.2928801.4056935562404690211.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=OJNEYQWB c=1 sm=1 tr=0 ts=62b4f390 a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=JPEYwPQDsx4A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=Mm4fXDbS6eUC7bzw250A:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Jun 23, 2022 at 01:40:06PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > The end of this function could use some cleanup -- the EAGAIN > conditionals make it harder to figure out what's going on with the > disposal of xattri_leaf_bp, and the dual error/ret variables aren't > needed. Turn the EAGAIN case into a separate block documenting all the > subtleties of recovering in the middle of an xattr update chain, which > makes the rest of the prologue much simpler. > > Signed-off-by: Darrick J. Wong Decent cleanup. :) Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com