From: Chris Dunlop <chris@onthe.net.au>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/6] xfs: break up xfs_buf_find() into individual pieces
Date: Tue, 28 Jun 2022 12:22:45 +1000 [thread overview]
Message-ID: <20220628022245.GA459863@onthe.net.au> (raw)
In-Reply-To: <20220627060841.244226-3-david@fromorbit.com>
On Mon, Jun 27, 2022 at 04:08:37PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> xfs_buf_find() is made up of three main parts: lookup, insert and
> locking. The interactions with xfs_buf_get_map() require it to be
> called twice - once for a pure lookup, and again on lookup failure
> so the insert path can be run. We want to simplify this down a lot,
> so split it into a fast path lookup, a slow path insert and a "lock
> the found buffer" helper. This will then let use integrate these
"let us"
next prev parent reply other threads:[~2022-06-28 2:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 6:08 [PATCH 0/6 v2] xfs: lockless buffer lookups Dave Chinner
2022-06-27 6:08 ` [PATCH 1/6] xfs: rework xfs_buf_incore() API Dave Chinner
2022-06-29 7:30 ` Christoph Hellwig
2022-06-29 21:24 ` Darrick J. Wong
2022-06-27 6:08 ` [PATCH 2/6] xfs: break up xfs_buf_find() into individual pieces Dave Chinner
2022-06-28 2:22 ` Chris Dunlop [this message]
2022-06-29 7:35 ` Christoph Hellwig
2022-06-29 21:50 ` Darrick J. Wong
2022-06-27 6:08 ` [PATCH 3/6] xfs: merge xfs_buf_find() and xfs_buf_get_map() Dave Chinner
2022-06-29 7:40 ` Christoph Hellwig
2022-06-29 22:06 ` Darrick J. Wong
2022-07-07 12:39 ` Dave Chinner
2022-06-27 6:08 ` [PATCH 4/6] xfs: reduce the number of atomic when locking a buffer after lookup Dave Chinner
2022-06-29 22:00 ` Darrick J. Wong
2022-06-27 6:08 ` [PATCH 5/6] xfs: remove a superflous hash lookup when inserting new buffers Dave Chinner
2022-06-29 7:40 ` Christoph Hellwig
2022-06-29 22:01 ` Darrick J. Wong
2022-06-27 6:08 ` [PATCH 6/6] xfs: lockless buffer lookup Dave Chinner
2022-06-29 7:41 ` Christoph Hellwig
2022-06-29 22:04 ` Darrick J. Wong
2022-07-07 12:36 ` Dave Chinner
2022-07-07 17:55 ` Darrick J. Wong
2022-07-11 5:16 ` Christoph Hellwig
2022-07-07 2:40 ` [PATCH 0/6 v2] xfs: lockless buffer lookups Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2022-07-07 23:52 [PATCH 0/6 v3] " Dave Chinner
2022-07-07 23:52 ` [PATCH 2/6] xfs: break up xfs_buf_find() into individual pieces Dave Chinner
2022-07-09 22:58 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628022245.GA459863@onthe.net.au \
--to=chris@onthe.net.au \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox