From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/6] mkfs: preserve DIFLAG2_NREXT64 when setting other inode attributes
Date: Wed, 29 Jun 2022 08:59:54 +1000 [thread overview]
Message-ID: <20220628225954.GQ227878@dread.disaster.area> (raw)
In-Reply-To: <165644937684.1089996.8013011825931751515.stgit@magnolia>
On Tue, Jun 28, 2022 at 01:49:36PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Preserve the state of the NREXT64 inode flag when we're changing the
> other flags2 fields. This is only vital for the kernel version of this
> function, but we should keep these in sync.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> libxfs/util.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
> diff --git a/libxfs/util.c b/libxfs/util.c
> index ef01fcf8..d2389198 100644
> --- a/libxfs/util.c
> +++ b/libxfs/util.c
> @@ -198,7 +198,8 @@ xfs_flags2diflags2(
> {
> uint64_t di_flags2 =
> (ip->i_diflags2 & (XFS_DIFLAG2_REFLINK |
> - XFS_DIFLAG2_BIGTIME));
> + XFS_DIFLAG2_BIGTIME |
> + XFS_DIFLAG2_NREXT64));
*nod*
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-06-28 23:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 20:49 [PATCHSET 0/6] xfsprogs: random fixes Darrick J. Wong
2022-06-28 20:49 ` [PATCH 1/6] xfs_copy: don't use cached buffer reads until after libxfs_mount Darrick J. Wong
2022-06-28 22:56 ` Dave Chinner
2022-06-29 7:44 ` Christoph Hellwig
2022-06-28 20:49 ` [PATCH 2/6] xfs_repair: clear DIFLAG2_NREXT64 when filesystem doesn't support nrext64 Darrick J. Wong
2022-06-28 22:58 ` Dave Chinner
2022-06-29 23:10 ` Darrick J. Wong
2022-06-30 22:51 ` Dave Chinner
2022-07-01 0:08 ` Darrick J. Wong
2022-07-01 0:12 ` [PATCH v2 " Darrick J. Wong
2022-07-01 1:08 ` Dave Chinner
2022-06-28 20:49 ` [PATCH 3/6] xfs_repair: detect and fix padding fields that changed with nrext64 Darrick J. Wong
2022-06-28 22:59 ` Dave Chinner
2022-06-28 20:49 ` [PATCH 4/6] mkfs: preserve DIFLAG2_NREXT64 when setting other inode attributes Darrick J. Wong
2022-06-28 22:59 ` Dave Chinner [this message]
2022-06-28 20:49 ` [PATCH 5/6] mkfs: document the large extent count switch in the --help screen Darrick J. Wong
2022-06-28 23:00 ` Dave Chinner
2022-06-28 20:49 ` [PATCH 6/6] mkfs: always use new_diflags2 to initialize new inodes Darrick J. Wong
2022-06-28 23:01 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628225954.GQ227878@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox