Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages

Felix Kuehling
2022-06-29T22:08:50Z

On 2022-06-29 03:33, David Hildenbrand wrote:
> On 29.06.22 05:54, Alex Sierra wrote:
>> is_pinnable_page() and folio_is_pinnable() were renamed to
>> is_longterm_pinnable_page() and folio_is_longterm_pinnable()
>> respectively. These functions are used in the FOLL_LONGTERM flag
>> context.
> Subject talks about "*_pages"
>
>
> Can you elaborate why the move from mm.h to memremap.h is justified?

Patch 2 adds is_device_coherent_page in memremap.h and updates
is_longterm_pinnable_page to call is_device_coherent_page. memremap.h
cannot include mm.h because it is itself included by mm.h. So the choice
was to move is_longterm_pinnable_page to memremap.h, or move
is_device_coherent_page and all its dependencies to mm.h. The latter
would have been a bigger change.

>
> I'd have called it "is_longterm_pinnable_page", but I am not a native
> speaker, so no strong opinion :)

I think only the patch title has the name backwards. The code uses
is_longterm_pinnable_page.

Regards,
Felix

>
>