From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B069CCA47F for ; Mon, 11 Jul 2022 04:15:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229599AbiGKEPU (ORCPT ); Mon, 11 Jul 2022 00:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbiGKEPT (ORCPT ); Mon, 11 Jul 2022 00:15:19 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB63F18B3F; Sun, 10 Jul 2022 21:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=73WQtLAfublxnxlmb+ZkF+V6P0Xfh+eOQ9htm4JxrAc=; b=cQwfRLvK8KLMevw7oa8CBlZs/N nF4WHCExa93/t4A09tR6i7JU7ez49yjMLlm3AI5qyMOLvU+9dd9maeVyZqtMsIRjXPxYcVNi+rrUm Mtu5bS5TMZviK8kjNca4AH3Hi4f7Jsta30coKH2ncBgGPRnX1xqqhVRXvkcM0vzFsTypE8dEaSYem KSFedbiCq7tpHkaTcxxSmyBRyXk7WZoPG3l+EVXH487yrfqm3rmgDVeaEOs7K+9xbNoAP9TmQPHsf esUxA8OZsTcbNa4klMaIMnxJ3fXrbTNN0x6SxgxZunvAzQ1UbWu/U1urKPpsl92j2yQ0Ihp/BUazx 38r6vUOg==; Received: from 089144197153.atnat0006.highway.a1.net ([89.144.197.153] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAkpC-00Fpwv-RI; Mon, 11 Jul 2022 04:15:11 +0000 From: Christoph Hellwig To: Bob Peterson , Andreas Gruenbacher , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota Cc: Johannes Thumshirn , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 3/4] zonefs: remove ->writepage Date: Mon, 11 Jul 2022 06:14:58 +0200 Message-Id: <20220711041459.1062583-4-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220711041459.1062583-1-hch@lst.de> References: <20220711041459.1062583-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org ->writepage is only used for single page writeback from memory reclaim, and not called at all for cgroup writeback. Follow the lead of XFS and remove ->writepage and rely entirely on ->writepages. Signed-off-by: Christoph Hellwig --- fs/zonefs/super.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index 053299758deb9..062c3f1da0327 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -232,13 +232,6 @@ static const struct iomap_writeback_ops zonefs_writeback_ops = { .map_blocks = zonefs_write_map_blocks, }; -static int zonefs_writepage(struct page *page, struct writeback_control *wbc) -{ - struct iomap_writepage_ctx wpc = { }; - - return iomap_writepage(page, wbc, &wpc, &zonefs_writeback_ops); -} - static int zonefs_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -266,7 +259,6 @@ static int zonefs_swap_activate(struct swap_info_struct *sis, static const struct address_space_operations zonefs_file_aops = { .read_folio = zonefs_read_folio, .readahead = zonefs_readahead, - .writepage = zonefs_writepage, .writepages = zonefs_writepages, .dirty_folio = filemap_dirty_folio, .release_folio = iomap_release_folio, -- 2.30.2