From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412A2C433EF for ; Mon, 11 Jul 2022 11:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230378AbiGKLNy (ORCPT ); Mon, 11 Jul 2022 07:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbiGKLN3 (ORCPT ); Mon, 11 Jul 2022 07:13:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 09D42DF65 for ; Mon, 11 Jul 2022 03:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657535279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sxcej8iLaxk6KCtDFxQeEdx04v8nRpskZBg7onOm+l0=; b=RASUHHexEtM3BuKoO9WRBJleH7oda7XovWY0y3aSoSpCWLkKwiMGB6RY6+RpO23YtSxwoO oPD96pTAKpylklI44/pFD0beAdWvASOv4wSzenS2z8L+LrOkaYmSaVxTMls9uCkvWEX5wx t0Dm/srum2aAbNpAGFKzlOhybDWhx1s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-356-EsQE4lh0OoW25cc4NkcRtA-1; Mon, 11 Jul 2022 06:27:50 -0400 X-MC-Unique: EsQE4lh0OoW25cc4NkcRtA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFCDB811E7A; Mon, 11 Jul 2022 10:27:49 +0000 (UTC) Received: from nux.com (unknown [10.40.192.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B6EA2026D64; Mon, 11 Jul 2022 10:27:47 +0000 (UTC) From: Andreas Gruenbacher To: Christoph Hellwig Cc: Andreas Gruenbacher , Bob Peterson , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one Date: Mon, 11 Jul 2022 12:27:47 +0200 Message-Id: <20220711102747.359525-1-agruenba@redhat.com> In-Reply-To: <20220711041459.1062583-2-hch@lst.de> References: <20220711041459.1062583-2-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Hello, On Mon, Jul 11, 2022 at 7:27 AM Christoph Hellwig wrote: > > Use filemap_fdatawrite_wbc instead of generic_writepages in > gfs2_ail1_start_one so that the functin can also cope with address_space > operations that only implement ->writepages and to properly account > for cgroup writeback. Reviewed-by: Andreas Gruenbacher I assume you want to push this through the xfs tree. Can you add the below follow-up cleanup? Thanks, Andreas --- fs/gfs2/log.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 624dffc96136..7fc6cb95dec8 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@ -222,8 +222,7 @@ void gfs2_ail1_flush(struct gfs2_sbd *sdp, struct writeback_control *wbc) spin_unlock(&sdp->sd_ail_lock); blk_finish_plug(&plug); if (ret) { - gfs2_lm(sdp, "gfs2_ail1_start_one (generic_writepages) " - "returned: %d\n", ret); + gfs2_lm(sdp, "gfs2_ail1_start_one returned %d\n", ret); gfs2_withdraw(sdp); } trace_gfs2_ail_flush(sdp, wbc, 0); -- 2.36.1