linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org,
	fstests@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 2/3] xfs/114: fix missing reflink requires
Date: Wed, 28 Sep 2022 18:06:05 +0800	[thread overview]
Message-ID: <20220928100605.c57deoxrwtuh42uj@zlang-mailbox> (raw)
In-Reply-To: <166433904232.2008389.13820157130628464952.stgit@magnolia>

On Tue, Sep 27, 2022 at 09:24:02PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> This test both requires cp --reflink and the scratch filesystem to
> support reflink.  Add the missing _requires calls.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  tests/xfs/114 |    2 ++
>  1 file changed, 2 insertions(+)
> 
> 
> diff --git a/tests/xfs/114 b/tests/xfs/114
> index 3aec814a5d..858dc3998e 100755
> --- a/tests/xfs/114
> +++ b/tests/xfs/114
> @@ -18,6 +18,8 @@ _begin_fstest auto quick clone rmap collapse insert
>  # real QA test starts here
>  _supported_fs xfs
>  _require_test_program "punch-alternating"
> +_require_cp_reflink
> +_require_scratch_reflink

Good to me,

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  _require_xfs_scratch_rmapbt
>  _require_xfs_io_command "falloc"
>  _require_xfs_io_command "fcollapse"
> 


  reply	other threads:[~2022-09-28 10:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28  4:23 [PATCHSET v23.1 0/3] fstests: random fixes for v2022.09.25 Darrick J. Wong
2022-09-28  4:23 ` [PATCH 1/3] generic/092: skip test if file allocation unit isn't aligned Darrick J. Wong
2022-09-28 10:04   ` Zorro Lang
2022-09-28  4:24 ` [PATCH 2/3] xfs/114: fix missing reflink requires Darrick J. Wong
2022-09-28 10:06   ` Zorro Lang [this message]
2022-09-28  4:24 ` [PATCH 3/3] xfs/229: do not _xfs_force_bdev on TEST_DIR Darrick J. Wong
2022-09-28 10:12   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220928100605.c57deoxrwtuh42uj@zlang-mailbox \
    --to=zlang@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).