From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: make rtbitmap ILOCKing consistent when scanning the rt bitmap file
Date: Fri, 14 Oct 2022 14:50:32 +1100 [thread overview]
Message-ID: <20221014035032.GK3600936@dread.disaster.area> (raw)
In-Reply-To: <166473480263.1083697.13141104857984829878.stgit@magnolia>
On Sun, Oct 02, 2022 at 11:20:02AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> xfs_rtalloc_query_range scans the realtime bitmap file in order of
> increasing file offset, so this caller can take ILOCK_SHARED on the rt
> bitmap inode instead of ILOCK_EXCL. This isn't going to yield any
> practical benefits at mount time, but we'd like to make the locking
> usage consistent around xfs_rtalloc_query_all calls. Make all the
> places we do this use the same xfs_ilock lockflags for consistency.
>
> Fixes: 4c934c7dd60c ("xfs: report realtime space information via the rtbitmap")
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_fsmap.c | 4 ++--
> fs/xfs/xfs_rtalloc.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
LGTM.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2022-10-14 3:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 18:20 [PATCHSET v23.1 0/2] xfs: improve rt metadata use for scrub Darrick J. Wong
2022-10-02 18:20 ` [PATCH 1/2] xfs: load rtbitmap and rtsummary extent mapping btrees at mount time Darrick J. Wong
2022-10-14 3:49 ` Dave Chinner
2022-10-02 18:20 ` [PATCH 2/2] xfs: make rtbitmap ILOCKing consistent when scanning the rt bitmap file Darrick J. Wong
2022-10-14 3:50 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014035032.GK3600936@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox